-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code property on aws.lambda.Function forces replacement #7
Comments
I know why this is happening, however it unfortunately turned up quite a number of problems. The root cause is that we regenerate I've filed pulumi/pulumi-terraform#17 to track working around this. Longer term, we need to do a bit of surgery on diffing in general here. We don't treat defaults the right way in general, when it comes to diffs, and we need to let the bridge get in on the game. |
This ingests fixes in pulumi/pulumi@5fb014e and pulumi/pulumi-terraform@f2eb1a2 which fixes the problem with Lambdas being erroenously replaced in #7.
# This is the 1st commit message: Fix import resources with provider default tags We have special logic around applying default provider tags to resources. This logic only applied to the `Check` call which means it was not applied when you were importing resources. This PR extends that logic to also run during the `Read` call. fix #4030, fix 4080 # This is the commit message #2: skip test # This is the commit message #3: fixing test # This is the commit message #4: Adding more tests # This is the commit message #5: Upgrade pulumi-terraform-bridge to v3.86.0 (#4160) This PR was generated via `$ upgrade-provider pulumi/pulumi-aws --kind=bridge --pr-reviewers=guineveresaenger`. Fixes #4091 Fixes #4137 --- - Upgrading pulumi-terraform-bridge from v3.85.0 to v3.86.0. - Upgrading pulumi-terraform-bridge/pf from v0.38.0 to v0.39.0. # This is the commit message #6: chore: run upstream provider-lint (#4120) This adds a step for running the upstream `provider-lint` make target. As part of this I had to fix some of the patches which violated some lint rules. **0009-Add-ECR-credentials_data_source.patch** - `ForceNew` does not apply to data sources **0032-DisableTagSchemaCheck-for-PF-provider.patch** - Schema have to have a `Type` - Also needed to add a ignore for `S013` which forces `Computed`, `Optional` or `Required` to be set. Looks like it can't recognize the `tagsComputed` var **0034-Fail-fast-when-PF-resources-are-dropped.patch** - Added a lint ignore for a rule which doesn't allow panics **0050-Normalize-retentionDays-in-aws_controltower_landing_.patch** - This test doesn't actually need a region or partition so replacing with a placeholder closes #4110 # This is the commit message #7: fix: CVE-2024-24791 (#4175) Fixes #4163 Upgrades minimally required Go versions to those unaffected by CVE-2024-24791.
It looks like changes to the
code
property on anaws.lambda.Function
are forcing it to be replaced. This causes a lot of churn as many things are keyed off of the function identity, and should not be necessary.If you deploy this:
and then change
"hello"
to"goodbye"
, you would expect to see just an in-place update of the function object. Instead, you see a replace followed by lots of create/deletes for dependent objects.(Note - the error at the end is presumably an unrelated bug that I'm investigating now).
The text was updated successfully, but these errors were encountered: