WIP: fix(ecsservice): triggers required when using forceNewDeployment #4262

stooj · 2024-07-19T08:51:49Z

There is a note saying you need to set forceNewDeployment when adding triggers.

The reverse is also true, so adding a note to say that triggers are required when adding forceNewDeployment.

github-actions · 2024-07-19T09:20:17Z

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

t0yv0 · 2024-07-19T18:22:34Z

/run-acceptance-tests

stooj · 2024-08-07T12:24:41Z

Fixes #4162

t0yv0 · 2024-08-07T21:01:44Z

Hi @stooj sorry dropped the ball here. @flostadler could you have a look as part of ops, something's not quite setup in CI to accept docs contributions but if we rerun make tfgen && make build_sdks this contrib should be fine I suspect.

stooj · 2024-08-08T08:50:21Z

No worries - I didn't spend the time to set up my local environment for dev contributions (I thought "it's just the docs") but since it's auto-generated I should have checked it locally.

t0yv0 · 2024-08-08T15:36:11Z

You're pointing out a real miss we have here, we'd love to remove friction from "just the docs" contributions. I'll talk to the team.

flostadler · 2024-08-19T13:00:27Z

@stooj if you want I can run the re-gen steps. Just lmk

stooj · 2024-08-20T08:44:43Z

@flostadler That'd be great, thanks.

github-actions · 2024-08-20T13:18:10Z

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

flostadler · 2024-08-20T13:20:00Z

provider/cmd/pulumi-resource-aws/schema.json

@@ -245414,7 +245414,7 @@
                },
                "forceNewDeployment": {
                    "type": "boolean",
-                    "description": "Enable to force a new task deployment of the service. This can be used to update tasks to use a newer Docker image with same image/tag combination (e.g., `myimage:latest`), roll Fargate tasks onto a newer platform version, or immediately deploy `ordered_placement_strategy` and `placement_constraints` updates.\n"
+                    "description": "Enable to force a new task deployment of the service. This can be used to update tasks to use a newer Docker image with same image/tag combination (e.g., `myimage:latest`), roll Fargate tasks onto a newer platform version, or immediately deploy `ordered_placement_strategy` and `placement_constraints` updates.\nWhen using the forceNewDeployment property you also need to configure the Triggers property.\n"


Nit: we have two different styles of property naming in the description now. (placement_constraints vs forceNewDeployment)

In my understanding forceNewDeployment is the preferred style when we cannot inflect toward the target language.

flostadler · 2024-08-20T13:20:52Z

@stooj Done!
@t0yv0 @corymhall can you have a look at the changes? Given that I authored parts of the changes I shouldn't review them.

github-actions · 2024-08-20T13:31:47Z

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

t0yv0 · 2024-08-20T14:15:20Z

provider/doc_edits.go

+		"This can be used to update tasks to use a newer Docker image with same image/tag combination "+
+		"(e.g., `myimage:latest`), roll Fargate tasks onto a newer platform version, or immediately deploy "+
+		"`ordered_placement_strategy` and `placement_constraints` updates.\n"+
+		"When using the forceNewDeployment property you also need to configure the Triggers property.\n")


Is Triggers capitalized intentionally? IN the most used language TypeScript it's probably not capitalized.

t0yv0

Thank you!

flostadler · 2024-08-20T14:17:02Z

/run-acceptance-tests

pulumi-bot · 2024-08-20T14:17:56Z

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/10473376111

github-actions · 2024-08-21T16:21:32Z

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

flostadler · 2024-08-21T17:06:31Z

/run-acceptance-tests

pulumi-bot · 2024-08-21T17:07:29Z

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/10494287999

flostadler · 2024-08-22T06:30:43Z

Acceptance tests were successful. Bypassing branch protection rules because they're waiting for sentinel

pulumi-bot · 2024-08-23T10:37:38Z

This PR has been shipped in release v6.50.1.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | patch | [`6.50.0` -> `6.50.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.50.0/6.50.1) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.50.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.50.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.50.0...v6.50.1) ##### Does the PR have any schema changes? Found 1 breaking change: ##### Resources - `🟢` "aws:pinpoint/gcmChannel:GcmChannel": required: "apiKey" property is no longer Required ##### New functions: - `route53/getZones.getZones` - `ssoadmin/getPermissionSets.getPermissionSets` ##### What's Changed - WIP: fix(ecsservice): triggers required when using forceNewDeployment by [@stooj](https://togithub.com/stooj) in [pulumi/pulumi-aws#4262 - Upgrade upstream to v5.63.1 by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4390 ##### New Contributors - [@stooj](https://togithub.com/stooj) made their first contribution in [pulumi/pulumi-aws#4262 **Full Changelog**: pulumi/pulumi-aws@v6.50.0...v6.50.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | patch | [`6.50.0` -> `6.50.1`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.50.0/6.50.1) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.50.1`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.50.1) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.50.0...v6.50.1) ##### Does the PR have any schema changes? Found 1 breaking change: ##### Resources - `🟢` "aws:pinpoint/gcmChannel:GcmChannel": required: "apiKey" property is no longer Required ##### New functions: - `route53/getZones.getZones` - `ssoadmin/getPermissionSets.getPermissionSets` ##### What's Changed - WIP: fix(ecsservice): triggers required when using forceNewDeployment by [@stooj](https://togithub.com/stooj) in [pulumi/pulumi-aws#4262 - Upgrade upstream to v5.63.1 by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4390 ##### New Contributors - [@stooj](https://togithub.com/stooj) made their first contribution in [pulumi/pulumi-aws#4262 **Full Changelog**: pulumi/pulumi-aws@v6.50.0...v6.50.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

fix(ecsservice): triggers required when using forceNewDeployment

a992149

flostadler added 3 commits August 20, 2024 14:47

Merge branch 'master' into force-deploy-note

b2b9691

Regenerate schema

447e237

Regenerate sdks

e4b89bd

flostadler reviewed Aug 20, 2024

View reviewed changes

Add java sdk

94a41c1

flostadler requested review from t0yv0 and corymhall August 20, 2024 13:50

flostadler assigned stooj and flostadler Aug 20, 2024

t0yv0 reviewed Aug 20, 2024

View reviewed changes

t0yv0 approved these changes Aug 20, 2024

View reviewed changes

Change Triggers to triggers

0062427

flostadler merged commit bde3081 into pulumi:master Aug 22, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: fix(ecsservice): triggers required when using forceNewDeployment #4262

WIP: fix(ecsservice): triggers required when using forceNewDeployment #4262

stooj commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

t0yv0 commented Jul 19, 2024

stooj commented Aug 7, 2024

t0yv0 commented Aug 7, 2024 •

edited

Loading

stooj commented Aug 8, 2024

t0yv0 commented Aug 8, 2024

flostadler commented Aug 19, 2024

stooj commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

flostadler Aug 20, 2024

t0yv0 Aug 20, 2024

flostadler commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

t0yv0 Aug 20, 2024

t0yv0 left a comment

flostadler commented Aug 20, 2024

pulumi-bot commented Aug 20, 2024

github-actions bot commented Aug 21, 2024

flostadler commented Aug 21, 2024

pulumi-bot commented Aug 21, 2024

flostadler commented Aug 22, 2024

pulumi-bot commented Aug 23, 2024

WIP: fix(ecsservice): triggers required when using forceNewDeployment #4262

WIP: fix(ecsservice): triggers required when using forceNewDeployment #4262

Conversation

stooj commented Jul 19, 2024

github-actions bot commented Jul 19, 2024

t0yv0 commented Jul 19, 2024

stooj commented Aug 7, 2024

t0yv0 commented Aug 7, 2024 • edited Loading

stooj commented Aug 8, 2024

t0yv0 commented Aug 8, 2024

flostadler commented Aug 19, 2024

stooj commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

flostadler Aug 20, 2024

Choose a reason for hiding this comment

t0yv0 Aug 20, 2024

Choose a reason for hiding this comment

flostadler commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

t0yv0 Aug 20, 2024

Choose a reason for hiding this comment

t0yv0 left a comment

Choose a reason for hiding this comment

flostadler commented Aug 20, 2024

pulumi-bot commented Aug 20, 2024

github-actions bot commented Aug 21, 2024

flostadler commented Aug 21, 2024

pulumi-bot commented Aug 21, 2024

flostadler commented Aug 22, 2024

pulumi-bot commented Aug 23, 2024

t0yv0 commented Aug 7, 2024 •

edited

Loading