Upgrade CallbackFunction default runtime to Node 20.x #4348

t0yv0 · 2024-08-06T22:32:13Z

This is a breaking change for users of Node automatically provisioned lambdas, moving them from the Node 16.x to Node 20.x runtime without an ability to opt out.

Prior to this change, Lambda functions provisioned in Node with CallbackFunction and helper methods such as Bucket.onObjectRemoved, Bucket.onObjectCreated or sns.Topic.onEvent used Node 16.x runtime by default. Per lambda-runtimes.html this is now deprecated by AWS. After the change, the new default runtime is Node 20.x.

Fixes #4134

The change is supported by strengthening a test to utilize fetch() API that was made available in 18.x and exercise the callback function at runtime.

github-actions · 2024-08-06T22:49:13Z

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

corymhall

Just 1 suggestion

corymhall · 2024-08-07T12:52:27Z

sdk/nodejs/lambda/lambdaMixins.ts

        const functionArgs = {
            ...args,
            code: code,
            handler: serializedFileNameNoExtension + "." + handlerName,
-            runtime: args.runtime || Runtime.NodeJS16dX,
+            runtime: args.runtime || Runtime.NodeJS18dX,


Should we take the opportunity to just upgrade to 20x?

You are right, #4134 was suggesting 18 as the current LTS but https://endoflife.date/nodejs suggests 20 is the current LTS so that should be reasonable.

flostadler

Even though it's a breaking change I think not doing it would be a greater issue for our users.
Function creates using node 16 will be blocked on Feb 28, 2025 and updates will be blocked on Mar 31, 2025.

We should really directly upgrade to node 20 though. The node 18 runtime is still using AL2 under the hood (see AWS docs) which will be deprecated in June 2025. There's a high chance they'll deprecate Node 18 as well in the near future.

flostadler · 2024-08-07T15:50:33Z

We should mark the Node 16.x runtime as deprecated as well: https://github.com/pulumi/pulumi-aws/blob/master/provider/resources.go#L4541

flostadler · 2024-08-07T15:56:17Z

sdk/nodejs/lambda/lambdaMixins.ts

@@ -406,13 +406,11 @@ export class CallbackFunction<E, R> extends LambdaFunction {
        // Copy over all option values into the function args.  Then overwrite anything we care


Can't put the comment on that line because it's outside of the PR, but we should also update the docs to reflect the new default:

pulumi-aws/sdk/nodejs/lambda/lambdaMixins.ts

Line 227 in 7461d68

* The Lambda runtime to use. If not provided, will default to [NodeJS8d10Runtime]

Seems like that docstring is outdated anyways right now :(

flostadler

Nice!

t0yv0 · 2024-08-07T21:21:34Z

PTAL @flostadler addressed the feedback.

Even though it's a breaking change I think not doing it would be a greater issue for our users.

I suspect just a slightly unexpected upgrade. Just calling it out for the release notes, still doing a minor release on this. Some more discussion on this in #4134

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.48.0` -> `6.49.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.48.0/6.49.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.49.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.48.0...v6.49.0) ##### Does the PR have any schema changes? Looking good! No breaking changes found. ##### New resources: - `ebs/snapshotBlockPublicAccess.SnapshotBlockPublicAccess` - `lambda/callbackFunction.CallbackFunction` - `rds/integration.Integration` ##### New functions: - `rds/getClusterParameterGroup.getClusterParameterGroup` - `secretsmanager/getSecretVersions.getSecretVersions` ##### What's Changed - Update GitHub Actions workflows. by [@pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#4353 - Upgrade CallbackFunction default runtime to Node 20.x by [@t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#4348 - Schematize lambda.CallbackFunction overlay and add docs for it by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4352 - Upgrade terraform-provider-aws to v5.62.0 by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4359 **Full Changelog**: pulumi/pulumi-aws@v6.48.0...v6.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://togithub.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.48.0` -> `6.49.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.48.0/6.49.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.49.0`](https://togithub.com/pulumi/pulumi-aws/releases/tag/v6.49.0) [Compare Source](https://togithub.com/pulumi/pulumi-aws/compare/v6.48.0...v6.49.0) ##### Does the PR have any schema changes? Looking good! No breaking changes found. ##### New resources: - `ebs/snapshotBlockPublicAccess.SnapshotBlockPublicAccess` - `lambda/callbackFunction.CallbackFunction` - `rds/integration.Integration` ##### New functions: - `rds/getClusterParameterGroup.getClusterParameterGroup` - `secretsmanager/getSecretVersions.getSecretVersions` ##### What's Changed - Update GitHub Actions workflows. by [@pulumi-bot](https://togithub.com/pulumi-bot) in [pulumi/pulumi-aws#4353 - Upgrade CallbackFunction default runtime to Node 20.x by [@t0yv0](https://togithub.com/t0yv0) in [pulumi/pulumi-aws#4348 - Schematize lambda.CallbackFunction overlay and add docs for it by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4352 - Upgrade terraform-provider-aws to v5.62.0 by [@flostadler](https://togithub.com/flostadler) in [pulumi/pulumi-aws#4359 **Full Changelog**: pulumi/pulumi-aws@v6.48.0...v6.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

mikhailshilkov · 2024-08-19T12:45:15Z

This PR has been shipped in release v6.49.0.

t0yv0 added 4 commits August 6, 2024 16:52

Extend testing to check fetch() support

6f718f4

Upgrade default CallbackFunction runtime to Node 18.x

31fb929

Do not run UpdateTest

280d6ba

Fixup test expectations

b7622c4

t0yv0 requested a review from corymhall August 6, 2024 22:38

corymhall approved these changes Aug 7, 2024

View reviewed changes

flostadler requested changes Aug 7, 2024

View reviewed changes

flostadler reviewed Aug 7, 2024

View reviewed changes

flostadler mentioned this pull request Aug 7, 2024

Schematize lambda.CallbackFunction overlay and add docs for it #4352

Merged

Default to Node 20.x instead

ffa0fde

t0yv0 changed the title ~~Upgrade CallbackFunction default runtime to Node 18.x~~ Upgrade CallbackFunction default runtime to Node 20.x Aug 7, 2024

t0yv0 added 5 commits August 7, 2024 16:06

Add a deprecation message for nodejs16.x

6023f2d

Mark Node 16 runtime as deprecated

f718365

make tfgen

fb8d06b

make build_sdks

7270a9b

Update doc comment

9193b54

flostadler approved these changes Aug 7, 2024

View reviewed changes

t0yv0 requested a review from flostadler August 7, 2024 21:20

t0yv0 merged commit 2a3dd78 into master Aug 8, 2024
30 checks passed

t0yv0 deleted the t0yv0/fix-4134 branch August 8, 2024 15:19

mjeffryes assigned t0yv0 Aug 9, 2024

mjeffryes added this to the 0.108 milestone Aug 16, 2024

mikhailshilkov mentioned this pull request Aug 19, 2024

Default Node runtime for lambdaMixins is out of LTS (and marked as EOL) #4134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade CallbackFunction default runtime to Node 20.x #4348

Upgrade CallbackFunction default runtime to Node 20.x #4348

t0yv0 commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024

corymhall left a comment

corymhall Aug 7, 2024

t0yv0 Aug 7, 2024

flostadler left a comment

flostadler commented Aug 7, 2024

flostadler Aug 7, 2024 •

edited

Loading

flostadler left a comment

t0yv0 commented Aug 7, 2024 •

edited

Loading

mikhailshilkov commented Aug 19, 2024

		@@ -406,13 +406,11 @@ export class CallbackFunction<E, R> extends LambdaFunction {
		// Copy over all option values into the function args. Then overwrite anything we care

Upgrade CallbackFunction default runtime to Node 20.x #4348

Upgrade CallbackFunction default runtime to Node 20.x #4348

Conversation

t0yv0 commented Aug 6, 2024 • edited Loading

github-actions bot commented Aug 6, 2024

Does the PR have any schema changes?

corymhall left a comment

Choose a reason for hiding this comment

corymhall Aug 7, 2024

Choose a reason for hiding this comment

t0yv0 Aug 7, 2024

Choose a reason for hiding this comment

flostadler left a comment

Choose a reason for hiding this comment

flostadler commented Aug 7, 2024

flostadler Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

flostadler left a comment

Choose a reason for hiding this comment

t0yv0 commented Aug 7, 2024 • edited Loading

mikhailshilkov commented Aug 19, 2024

t0yv0 commented Aug 6, 2024 •

edited

Loading

flostadler Aug 7, 2024 •

edited

Loading

t0yv0 commented Aug 7, 2024 •

edited

Loading