Update README.md to remove outdated helm instructions #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeffryes
added
the
impact/no-changelog-required
|
The linting check error seems to just be that it wants a chart version bump, but I don't think that makes sense b/c this is just a readme change. |
rquitales
force-pushed
the
mjeffryes-patch-1
branch
from
ef193cf
to
a29c820
Compare
rquitales
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
@mjeffryes FYI reworked this PR to:
- Replicate the readme changes you made into the readme template, since the publish steps uses the template file for generating a readme
- Updated the title of the readme - I noticed it's using the name of another project
- Skip chart linting and publish if only the readme is updated
I'll let you do a final look over and have you merge it.
|
Totally missed that this was a template! Thanks for cleaning up after me @rquitales! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We apparently only support installing via the oci artifact. (#544 (comment))
Fixes #544