Ensure that resource group naming is deterministic #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff for pulumi-azuread with merge commit 4799ee6 |
|
Diff for pulumi-random with merge commit 4799ee6 |
jazzyfresh
approved these changes
Apr 27, 2023
|
Diff for pulumi-gcp with merge commit 4799ee6 |
|
Diff for pulumi-azure with merge commit 4799ee6 |
|
I'm unable to repro the original issue in a contained test. I'm going to merge now and add a follow-up issue to add a test. |
| } | ||
| sort.Strings(keys) | ||
|
|
||
| for _, name := range keys { |
There was a problem hiding this comment.
You could probably do a one-liner
for _, name := range codegen.SortedKeys(resourceGroups) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pulumi/pulumi-gitlab#224
This bug manifested as occasionally missing (or emerging) example blocks in gitlab (and I suspect aws).