Skip to content

Commit

Permalink
py: phantomjs service needs to really kill the spawned process
Browse files Browse the repository at this point in the history
Fixes Issue SeleniumHQ#5921
  • Loading branch information
lukeis committed Nov 7, 2013
1 parent 76342ca commit 885b62b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion py/selenium/webdriver/phantomjs/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
# limitations under the License.
import subprocess
import time
import signal

from selenium.common.exceptions import WebDriverException
from selenium.webdriver.common import utils
Expand Down Expand Up @@ -91,7 +92,7 @@ def stop(self):
#Tell the Server to properly die in case
try:
if self.process:
self.process.kill()
self.process.send_signal(signal.SIGTERM)
self.process.wait()
except OSError:
# kill may not be available under windows environment
Expand Down

0 comments on commit 885b62b

Please sign in to comment.