Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2030 Only establish dependency between service and package if package is managed. #745

Conversation

jonnytdevops
Copy link
Contributor

No description provided.

@danzilio
Copy link

danzilio commented Aug 6, 2015

Isn't the wording a little awkward? Most places this parameter is called manage_package not package_manage

@jonnytdevops
Copy link
Contributor Author

This PR doesn't add or modify the param, just makes use of it properly.

@danzilio
Copy link

danzilio commented Aug 6, 2015

I was just about to update my comment with that ;)

tphoney added a commit that referenced this pull request Aug 6, 2015
…-depencency-when-managed

#2030 Only establish dependency between service and package if package is managed.
@tphoney tphoney merged commit 4049258 into puppetlabs:master Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants