Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firewall_rules module #97

Merged
merged 61 commits into from
Apr 17, 2024
Merged

Add firewall_rules module #97

merged 61 commits into from
Apr 17, 2024

Conversation

DonGiovanni83
Copy link
Contributor

Those Changes add first version of a firewall rule module.

@DonGiovanni83 DonGiovanni83 force-pushed the feature/fw-rules branch 4 times, most recently from 85d5194 to 1a99f3a Compare April 16, 2024 13:10
@DonGiovanni83 DonGiovanni83 mentioned this pull request Apr 16, 2024
Open
@DonGiovanni83 DonGiovanni83 linked an issue Apr 16, 2024 that may be closed by this pull request
Module Request: firewall_rules #98
Closed
rekup
rekup reviewed Apr 16, 2024
View reviewed changes
molecule/firewall_rules/converge.yml Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Outdated Show resolved Hide resolved
plugins/module_utils/module_index.py Show resolved Hide resolved
plugins/modules/firewall_rules.py Outdated Show resolved Hide resolved
@DonGiovanni83 DonGiovanni83 added this to the v1.0.0 milestone Apr 17, 2024
DonGiovanni83 and others added 21 commits April 17, 2024 11:34
@DonGiovanni83
Init module index for firewall rule module
f6e1168
@DonGiovanni83
Init firewall_rules doc
1881bd7
@DonGiovanni83
Init firewall rules utils
8d9fb7a
@DonGiovanni83
Init firewall rule module
dbd2a7b
@DonGiovanni83
Add import sed target for local debugging
987647a
@KiLLuuuhh @DonGiovanni83
remove findall function
353d392
@KiLLuuuhh @DonGiovanni83
removed findall function
b9b4f85
@KiLLuuuhh @DonGiovanni83
added docstring to from_xml
25f2ab6
@KiLLuuuhh @DonGiovanni83
added docstrings to various functions
e65f6e1
@KiLLuuuhh @DonGiovanni83
removed comments since docstring is covering them
6fa8c20
@KiLLuuuhh @DonGiovanni83
fixed linter errors
07d6fcd
@KiLLuuuhh @DonGiovanni83
added unit test to check enum attribute not existing handling
c6cdc0a
@KiLLuuuhh @DonGiovanni83
added docstrings for class FirewallRuleSet
f255962
@KiLLuuuhh @DonGiovanni83
updated documentation
3fe12fc
@KiLLuuuhh @DonGiovanni83
added disabled handler and corresponding unit test
14284f0
@KiLLuuuhh @DonGiovanni83
added quick handle and tests
c96fb12
@KiLLuuuhh @DonGiovanni83
added extended testing to test all features except log, category
a2139e9
@KiLLuuuhh @DonGiovanni83
added log handle
93a7f91
@KiLLuuuhh @DonGiovanni83
first draft of converge tets
9a0a787
@KiLLuuuhh @DonGiovanni83
revert Makefile change
b1db8f9
@KiLLuuuhh @DonGiovanni83
updated the documentation
dbbb5b4
@DonGiovanni83
Add missing test for fw rule target factory
513a950
@DonGiovanni83
Add target attribute to fw rule target
c80640a
@DonGiovanni83
Cleanup fw rules utils
6aef036
@DonGiovanni83
Fix string equality check in fw rule tests
5910baf
@DonGiovanni83
Refactor fw rules module params
ce9cd9d
@DonGiovanni83
Implement proper source & destination targets in fw rules
0d7df4a
@DonGiovanni83
Fix missing defaults in module param documentation
5e84494
@DonGiovanni83
Make test root a module
04f0f25
@DonGiovanni83
Format exception message
6da76b5
@DonGiovanni83
Fix config util test
5a13f2f
@DonGiovanni83
Finalize firewall_rule molecule tests
65e7b39
@DonGiovanni83
Fix fw rule invert value handling
0182e82
@DonGiovanni83
Fix ansible module params default handling for fw rule
7d3fa04
@DonGiovanni83
Fix fw rule set delete
417ac88
@DonGiovanni83
Add 24.1 support for fw rule
56b248e
@DonGiovanni83
Update fw rule module doc
84a0ed9
@DonGiovanni83
Add fw rule target inversino test cases
6fc3f18
@DonGiovanni83
Add tests for 22.7,23.7 and fix module index
1108732
@DonGiovanni83
Format changes
09d8db5
@DonGiovanni83
Lint and cleanup firewall_rules related tests
ea807f1
@DonGiovanni83
Format and lint firewal_rules plugins
7f71ed8
@DonGiovanni83 DonGiovanni83 merged commit ddc4122 into puzzle:main Apr 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekup rekup rekup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Module Request: firewall_rules
3 participants
@DonGiovanni83 @rekup @KiLLuuuhh