Staging #4549
Merged
Staging #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintenance task. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com>
…4508) fixes #4504, #4474 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> 1. No current support for Offline Support 2. No current separation of Security Tests 3. html`` being returned in ternary operators instead of null 4. The red icon inside the filter button in the action items list changes sizes when clicked to become active. 5. Cannot tab inside the tooltips (Community, SW and Manifest tooltips) 6. Upon pressing the retest button, the app capabilities score weren't resetting. ## Describe the new behavior? 1. Offline support inside the SW card 2. New Security warning when delivering mixed content. Can package with warning. 3. return null where it makes sense instead of html`` 4. Icon stays the same size. 5. Can now use arrow keys to get inside tooltips to the links (learn more, edit in manifest, or the community links) 6. App Capabilities score now resets properly ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Beth Pan <xupa@microsoft.com>
fixes #4531 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> Build or CI related changes <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Tests were failing because of the issue described in the linked bug. ## Describe the new behavior? Tests have been updated to: - account for the `visually-hidden` text - properly wait on the tests to pass before testing to see if the package button is disabled or not ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [ xTarget main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Beth Pan <xupa@microsoft.com>
Updated header to the designs we agreed upon for the uniform header work that Sana has been doing.
|
Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-4549.eastus2.azurestaticapps.net |
khmyznikov
reviewed
Nov 29, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-field-047c1420f-4549.eastus2.azurestaticapps.net |
Jaylyn-Barbee
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #[issue number]
PR Type
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run testand ensure that all tests passAdditional Information