Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #4623

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Staging #4623

Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[FIX] #4584: Dismiss feedback messages when modal is closed (#4588)
fixes #4584 

Feedback messages were persisting when package modal was closed, added a
line to clear them out.
  • Loading branch information
zateutsch committed Jan 1, 2024
commit 2993f5bab2c6875f1c92eaca0875b487edc8e97a
3 changes: 2 additions & 1 deletion apps/pwabuilder/src/script/components/publish-pane.ts
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,7 @@ export class PublishPane extends LitElement {
if(e.target === dialog){
this.blob = undefined;
this.generating = false;
this.feedbackMessages = [];
await dialog!.hide();
recordPWABuilderProcessStep("publish_pane_closed", AnalyticsBehavior.ProcessCheckpoint);
document.body.style.height = "unset";
Expand Down Expand Up @@ -1049,7 +1050,7 @@ export class PublishPane extends LitElement {
class=${classMap({noX: this.preventClosing, dialog: true})}
@sl-hide=${(e: any) => this.hideDialog(e)}
@sl-request-close=${(e:any) => this.handleRequestClose(e)}
noHeader
noHeader
>
<div id="pp-frame-wrapper">
<div id="pp-frame-content">
Expand Down
Loading