Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build arm64 on macos-14 #290

Closed
wants to merge 3 commits into from
Closed

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 6, 2024

just trying

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f4ac7c3) to head (094c5a7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1930      1930           
=========================================
  Hits          1930      1930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 6, 2024

CodSpeed Performance Report

Merging #290 will improve performances by 11.87%

Comparing tlambert03:arm64 (094c5a7) with main (f4ac7c3)

Summary

⚡ 1 improvements
✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark main tlambert03:arm64 Change
test_emit_time[lambda-2] 127.9 µs 114.3 µs +11.87%

@tlambert03
Copy link
Member Author

no good:

Warning: While cibuildwheel can build CPython 3.8 universal2/arm64 wheels, we cannot test the arm64 part of them, even when running on an Apple Silicon machine. This is because we use the x86_64 installer of CPython 3.8. See the discussion in pypa/cibuildwheel#1169 for the details. To silence this warning, set CIBW_TEST_SKIP: "cp38-macosx_*:arm64".

@tlambert03 tlambert03 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant