Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pre-commit hooks #234

Merged
merged 2 commits into from
Mar 13, 2024
Merged

chore: update pre-commit hooks #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32e946e
chore: update pre-commit hooks
pre-commit-ci[bot] Mar 12, 2024
2b238e4
style: pre-commit fixes
pre-commit-ci[bot] Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ci:

repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: "v0.2.2"
rev: "v0.3.2"
hooks:
- id: ruff
args: [--fix, --show-fixes]
Expand Down
1 change: 1 addition & 0 deletions docs/_extension/gallery_directive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

Credit: PyData Sphinx Theme
"""

from pathlib import Path
from typing import Any, Dict, List

Expand Down
8 changes: 3 additions & 5 deletions pybop/parameters/parameter_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,9 @@ def _handle_special_cases(self):
"Open-circuit voltage [V]" in self.params
and self.params["Open-circuit voltage [V]"] == "default"
):
self.params[
"Open-circuit voltage [V]"
] = pybop.empirical.Thevenin().default_parameter_values[
"Open-circuit voltage [V]"
]
self.params["Open-circuit voltage [V]"] = (
pybop.empirical.Thevenin().default_parameter_values["Open-circuit voltage [V]"]
)

def export_parameters(self, output_json_path, fit_params=None):
"""
Expand Down
Loading