Add support for AES-GCM-SIV using OpenSSL>=3.2.0
#9843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
7 times, most recently
from
f67ef4e
to
34aed6a
Compare
|
Should be possible to get this to green now that 3.2.0 is out, and we're using it in CI |
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
from
34aed6a
to
b47723d
Compare
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
8 times, most recently
from
5587e45
to
8e83704
Compare
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
from
8e83704
to
e3d316f
Compare
|
vectors are merged, although let's make sure we have an AAD non-zero, PT zero test case too since OpenSSL has had bugs with that type of split in AEADs in the past. Assuming GCM-SIV allows that 😄 |
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
from
e3d316f
to
7c8a12a
Compare
|
There's a workaround for the benchmark issue on main, so you can rebase |
facutuesca
force-pushed
the
add-aes-gcm-siv
branch
from
7c8a12a
to
afa0ffa
Compare
reaperhulk
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.2.0 has added support for AES-GCM-SIV (issue, PR). It is defined in RFC 8452.
This PR adds support for it through the Rust bindings. The implementation is based on already existing AEADs, but adapted to the specifics of AES-GCM-SIV.
The test vectors are from OpenSSL (source)
This PR is part of #9795.