Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge README content into the main index doc page #97

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

mrocklin
Copy link
Collaborator

This adds some informative content to the documentation
and centralizes our prose in one place.

This adds some informative content to the documentation
and centralizes our prose in one place.
@hameerabbasi
Copy link
Collaborator

This seems fine to me. I'm sorry to piggy back on this issue, but I didn't want to open another one, what about the PyData domain?

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Jan 30, 2018

On second thought, could we add developer information to the GitHub README? Kind of like SciPy.

Just two links would be enough, with some very short dev intro, IMO:

  • Contributing
  • Docs

Also, can we add a section on filing issues in contributing?

Edit: And also rename contribute to contributing... GitHub picks it up and links it when opening a PR or issue that way.

@mrocklin
Copy link
Collaborator Author

mrocklin commented Jan 30, 2018 via email

* Fix all broken links in the docs.
* Add useful links to README.
@hameerabbasi
Copy link
Collaborator

@mrocklin, I could use your input here. :-)

@@ -9,7 +9,7 @@ Operators
---------

:obj:`COO` objects support a number of operations. They interact with scalars,
:obj:`numpy.ndarray` objects, other :obj:`COO` objects, and
:doc:`Numpy arrays <reference/generated/numpy.ndarray>`, other :obj:`COO` objects, and
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why was this change required?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying "numpy dot enn dee array objects" is a mouthful. I thought it would be easier for readers to just change it to "Numpy arrays."

@mrocklin
Copy link
Collaborator Author

mrocklin commented Feb 1, 2018

In general this seems fine to me. I'm in favor of merging.

@hameerabbasi hameerabbasi merged commit 678de28 into pydata:master Feb 1, 2018
hameerabbasi pushed a commit to hameerabbasi/sparse that referenced this pull request Feb 27, 2018
* Merge README content into the main index doc page

This adds some informative content to the documentation
and centralizes our prose in one place.

* Range of changes to docs.

* Fix all broken links in the docs.
* Add useful links to README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants