Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: correct dask array handling in _calc_idxminmax #3922

Merged
merged 23 commits into from
May 13, 2020
Merged

FIX: correct dask array handling in _calc_idxminmax #3922

merged 23 commits into from
May 13, 2020

Commits on Mar 31, 2020

  1. FIX: correct dask array handling in _calc_idxminmax

    @kmuehlbauer
    kmuehlbauer committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    12fe069 View commit details
    Browse the repository at this point in the history

  2. FIX: remove unneeded import, reformat via black

    @kmuehlbauer
    kmuehlbauer committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    59a74d6 View commit details
    Browse the repository at this point in the history

  3. fix idxmax, idxmin with dask arrays

    @dcherian
    dcherian committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    7369007 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. FIX: use array[dim].data in _calc_idxminmax as per @keewis suggesti… 

    …on, attach dim name to result
    @kmuehlbauer
    kmuehlbauer committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    9a862fc View commit details
    Browse the repository at this point in the history

  2. ADD: add dask tests to idxmin/idxmax dataarray tests

    @kmuehlbauer
    kmuehlbauer committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    b154c8a View commit details
    Browse the repository at this point in the history

  3. FIX: add back fixture line removed by accident

    @kmuehlbauer
    kmuehlbauer committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    bf5530b View commit details
    Browse the repository at this point in the history

  4. ADD: complete dask handling in idxmin/idxmax tests in test_dataar… 

    …ray, xfail dask tests for dtype dateime64 (M)
    @kmuehlbauer
    kmuehlbauer committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    a60ae89 View commit details
    Browse the repository at this point in the history

  5. ADD: add "support dask handling for idxmin/idxmax" in whats-new.rst

    @kmuehlbauer
    kmuehlbauer committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    e7c42c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Merge branch 'master' into fix-idxminmax-dask-issues

    @kmuehlbauer
    kmuehlbauer authored Apr 6, 2020
    Configuration menu
    Copy the full SHA
    8b2ac75 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Merge branch 'master' into fix-idxminmax-dask-issues

    @kmuehlbauer
    kmuehlbauer authored Apr 14, 2020
    Configuration menu
    Copy the full SHA
    36dc8ee View commit details
    Browse the repository at this point in the history

  2. MIN: reintroduce changes added by pydata#3953

    @kmuehlbauer
    kmuehlbauer committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    5c23327 View commit details
    Browse the repository at this point in the history

  3. MIN: change if-clause to use and instead of & as per review-comment

    @kmuehlbauer
    kmuehlbauer committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    081ff6f View commit details
    Browse the repository at this point in the history

  4. MIN: change if-clause to use and instead of & as per review-comment

    @kmuehlbauer
    kmuehlbauer committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    26cc8f3 View commit details
    Browse the repository at this point in the history

  5. WIP: remove dask handling entirely for debugging purposes

    @kmuehlbauer
    kmuehlbauer committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    613f4e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Test for dask computes

    @dcherian
    dcherian committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    8a95492 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. WIP: re-add dask handling (map_blocks-approach), add `with raise_if_d… 

    …ask_computes()` context to idxmin-tests
    @kmuehlbauer
    kmuehlbauer committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    8cf4f3e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Use dask indexing instead of map_blocks.

    @dcherian
    dcherian committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    4417a35 View commit details
    Browse the repository at this point in the history

  2. Better chunk choice.

    @dcherian
    dcherian committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    43384c3 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Return -1 for _nan_argminmax_object if all NaNs along dim

    @dcherian
    dcherian committed May 9, 2020
    Configuration menu
    Copy the full SHA
    58901b9 View commit details
    Browse the repository at this point in the history

  2. Revert "Return -1 for _nan_argminmax_object if all NaNs along dim" 

    This reverts commit 58901b9.
    @dcherian
    dcherian committed May 9, 2020
    Configuration menu
    Copy the full SHA
    cfc98da View commit details
    Browse the repository at this point in the history

  3. Raise error for object arrays

    @dcherian
    dcherian committed May 9, 2020
    Configuration menu
    Copy the full SHA
    c1324bf View commit details
    Browse the repository at this point in the history

  4. No error for object arrays. Instead expect 1 compute in tests.

    @dcherian
    dcherian committed May 9, 2020
    Configuration menu
    Copy the full SHA
    525118b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into fix-idxminmax-das… 

    …k-issues

* upstream/master: (22 commits)
  support darkmode (pydata#4036)
  Use literal syntax instead of function calls to create the data structure (pydata#4038)
  Add template xarray object kwarg to map_blocks (pydata#3816)
  Transpose coords by default (pydata#3824)
  Remove broken test for Panel with to_pandas() (pydata#4028)
  Allow warning with cartopy in docs plotting build (pydata#4032)
  Support overriding existing variables in to_zarr() without appending (pydata#4029)
  chore: Remove unnecessary comprehension (pydata#4026)
  fix to_netcdf docstring typo (pydata#4021)
  Pint support for DataArray (pydata#3643)
  Apply blackdoc to the documentation (pydata#4012)
  ensure Variable._repr_html_ works (pydata#3973)
  Fix handling of abbreviated units like msec (pydata#3998)
  full_like: error on non-scalar fill_value (pydata#3979)
  Fix some code quality and bug-risk issues (pydata#3999)
  DOC: add pandas.DataFrame.to_xarray (pydata#3994)
  Better chunking error messages for zarr backend (pydata#3983)
  Silence sphinx warnings (pydata#3990)
  Fix distributed tests on upstream-dev (pydata#3989)
  Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956)
  ...
    @dcherian
    dcherian committed May 9, 2020
    Configuration menu
    Copy the full SHA
    20ccf5a View commit details
    Browse the repository at this point in the history