Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chunks=None for dask-less lazy loading #6028

Closed
wants to merge 1 commit into from

Conversation

LunarLanding
Copy link

Otherwise, the preprocess step always gets a single chunk for each variable instead of the xarray lazy accessors; dask can't change the order of slicing / computing in most cases. The default is changed to {} to maintain the default behavior.

  • Closes #xxxx
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Otherwise, the preprocess step always gets a single chunk for each variable instead of the xarray lazy accessors; dask can't change the order of slicing / computing in most cases. The default is changed to {} to maintain the default behavior.
@keewis
Copy link
Collaborator

keewis commented Nov 25, 2021

this might be a duplicate of #5704. If I'm reading that correctly, the "only" thing missing is to add support to concatenation to our lazy indexing machinery.

@LunarLanding
Copy link
Author

@keewis thanks, it is a duplicate. it must work in my specific case because I was testing with just one file.

@LunarLanding LunarLanding deleted the patch-1 branch November 25, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants