Opt out of floor division for float dtype time encoding #9497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Awesome, really just right around the corner. Thanks so much @spencerkclark! |
kmuehlbauer
approved these changes
Sep 15, 2024
3 tasks
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Sep 17, 2024
* main: Opt out of floor division for float dtype time encoding (pydata#9497) fixed formatting for whats-new (pydata#9493)
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Sep 17, 2024
* main: Opt out of floor division for float dtype time encoding (pydata#9497) fixed formatting for whats-new (pydata#9493) Forbid modifying names of DataTree objects with parents (pydata#9494) DAS-2155 - Merge datatree documentation into main docs. (pydata#9033) Make illegal path-like variable names when constructing a DataTree from a Dataset (pydata#9378) Ensure TreeNode doesn't copy in-place (pydata#9482) `open_groups` for zarr backends (pydata#9469) Update pyproject.toml (pydata#9484) New whatsnew section (pydata#9483)
hollymandel
pushed a commit
to hollymandel/xarray
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a quick fix for #9488.
Previously for
datetime64[ns]andtimedelta64[ns]values we would always use floor division to encode times if we knew that all non-"NaT"values could be represented with integers with the given units, even if we would ultimately cast the values to floats later based on the specifieddtype. This causes a problem when encoding"NaT"values, because the placeholder integer value is converted to a float here, which prevents it from properly being filled with the fill value later in the encoding process.This PR changes things such that if we know that we will convert to floats eventually, we will use floating point division from the start, which preserves
"NaT"values as floating pointnp.nanvalues. I update and test the behavior for bothdatetime64[ns]values andtimedelta64[ns]values.cc: @kmuehlbauer
whats-new.rst