Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display date/time for last files synced. #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrewleech
Copy link

There has been a number of times I've wanted to double check the pydio ui to see if files have synced correctly, opened the recent files drop down, and still not known for sure whether the files listed were synced right now, or a couple of days ago.

This PR adds a date/time column to that list for each file.
It shows the time if the file synced today, else the date for older log entries.

Shows time if file synced today, else date for older logs.
@cdujeu
Copy link
Member

cdujeu commented Mar 24, 2015

Hi Andrew,
Nice to see more people contributing on this!
Just two things:

  • could you provide a screenshot of the result?
  • did you sign the CLA (see pyd.io/contribute/cla) ?
    cheers
    charles

@andrewleech
Copy link
Author

Ah, yes I had seen the CLA, sorry I'd completely forgotten to fill it out. Done Now :-)

Here's the screenshot, it's certainly a valid request.
I was unsure about the look at first, displaying both the time and date on each did not work well during initial testing - it pushed each entry onto two lines. Hence going with time or date depending on age. This screenshot shows both.
pydio _with_timestamps

@cdujeu
Copy link
Member

cdujeu commented Mar 25, 2015

Mmm, I think our UX guy will put his veto on that. We tried to keep all that as simple as possible. But I understand the need, what about using a tooltip that displays when your mouse flies over files? Also we could use the relativeDate we already use elsewhere to say "moments ago", "2 days ago", etc..
What do you think?
-c

@stephane-ruhlmann
Copy link
Contributor

I think the best solution is to combine Moment.js relative 'time from now' method with a tooltip to see the exact date/time.

@andrewleech
Copy link
Author

While I understand your position in keeping things as as natural language as possible, when it comes to my valuable data, and knowing for certain if it's synced correctly as I'm leaving the office to go on-site etc, I want certainty if/when it happened and something as arbitrary as 'moments ago' is too indeterminate.
Full disclosure, I'm and Engineer/Scientist, so I accept that I'm more particular than much of the public.

Perhaps a setting to switch date/time display from natural to exact, with natural as the default?

I had originally thought a tooltip would be good too, although if it's going to display a full timestamp immediately on hover it's likely to look pretty ugly itself depending on where it's anchored. It also adds extra steps/gestures to get the time information, which I consider a crucial part of any kind of logging readout.

@cdujeu
Copy link
Member

cdujeu commented Mar 26, 2015

Maybe on the right side of "Last Files Sync", we could simply add a "More Info" button, that would switch a display of the sync time, what do you think? I would in that case put that in a second line for each file, as adding column will not be very handy for long file names. We could also display the folder of each file, as here we only display the base name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants