-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling of prices #1342
Comments
* Handle cached prices better when eve-marketdata returns 0 for lack of price data (#1334)
@blitzmann did you think about getting prices directly from ESI? It has an api call for fetching all market orders in a region, optionally specifying type ID of the item. I've recently did this for my own eve related project and I think it works :) Class for getting prices is here - https://github.com/minlexx/whdbx_web/blob/master/classes/eve_price_resolver.py#L222 I think this code should be portable to py2 and can be added to pyfa without much efforts... I might even try to prepare a pull request some time in the future if you won't do it yourself first.. :) P.S. need to find where is my pyfa & py2 development environment was ... |
I did look at it briefly, and it is something I want to do eventually. I have a couple projects that I want to get done first that are more pressing though, especially since we have functioning price sources to begin with. I did take a brief look and found two endpoints: the average price across the universe, and the orders per region. The average price for the universe might be interesting, but would require a huge revamping of how prices get fetched (instead of fetching them individually when needed, we would have to fetch them in the background on startup), and I'm not sure of the performance impact of updating all the prices at once. The one for the region - also may require a bit more tweaking since pyfa gets prices based on system, not region. We could always get the orders for a region and limit the results based on system (if station locationID is in Jita), but that's additional API calls. Or, just simply specify in the preferences what kind of fetch the source does (for example, For now the two third-party sources work (well, two if evecentral ever comes back up). If you're interested in trying to tackle this for ESI, I'm open to PRs - will need to evaluate the performance impact of getting all orders for the region and calculating a good price point for each type we send in. The price sources are kind of plugin based - you create a class and register it with the Price service - it's EDIT: Actually, IIRC a conversation I had with |
Need to take a look at exactly the response we are getting back from the EVE Central api (which is currently down). We should fall back to eve-marketdata if central fails. This should prevent all the emails I'm getting about not being able to fetch prices >.<. Should also take a look at fixing #1334 up while in there.
The text was updated successfully, but these errors were encountered: