Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Fittings not working #1410

Closed
Neugeniko opened this issue Feb 19, 2018 · 3 comments
Closed

Import Fittings not working #1410

Neugeniko opened this issue Feb 19, 2018 · 3 comments
Labels
2.x Related tot he 2.x cycle of pyfa bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! logged Logged in changelog for release

Comments

@Neugeniko
Copy link
Contributor

This is for version 2.0.0b3

Clicking on File>Import fittings
then Selecting a EVE XML fitting file
results in the import dialog box hanging
and force close being the only recovery option
@blitzmann
Copy link
Collaborator

Thanks for the report(s)! All the broken things!

@blitzmann blitzmann added 2.x Related tot he 2.x cycle of pyfa In Progress This issue is currently being worked on. labels Feb 23, 2018
@blitzmann
Copy link
Collaborator

This seems to be due to all the encoding code that we had in place. Python 3 now defaults to utf, and so I'm hoping that we can remove the bulk of the codec juggling that we're doing for imports. I have this working now, but will want to test with fit names / fit name using unicode characters (chinese, russian, etc) to be on the safe side.

blitzmann added a commit that referenced this issue Feb 23, 2018
@blitzmann
Remove all encoding bits from fit importing. Might not work 100% of t…
201fb4e 
…he time, but as 2.0 gets introduced to the community, we'll get reports of possible problems. #1410
@blitzmann blitzmann added bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! and removed In Progress This issue is currently being worked on. labels Feb 23, 2018
@Neugeniko
Copy link
Contributor Author

Checked this with russian and chinese fits names and appears to work.

@blitzmann blitzmann mentioned this issue Mar 3, 2018
Closed
@blitzmann blitzmann added logged Logged in changelog for release and removed logged Logged in changelog for release labels Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related tot he 2.x cycle of pyfa bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! logged Logged in changelog for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blitzmann @Neugeniko