Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve sizing on esi fit import browser #1987

Merged
merged 1 commit into from
May 27, 2019

Conversation

AaronOpfer
Copy link
Contributor

On my machine, using the ESI import feature and clicking "Fetch Fits" gives the appearance of nothing happening. Turns out, this was because by default the tree on the left-hand side of the window has zero width by default and the parent window needs to be resized to see the fits. Fix this by setting a minimum size for the fitting browser tree and increase the default window size to compensate.

On my machine, using the ESI import feature and clicking "Fetch Fits" gives the appearance of nothing happening. Turns out, this was because by default the tree on the left-hand side of the window has zero width by default and the parent window needs to be resized to see the fits. Fix this by setting a minimum size for the fitting browser tree and increase the default window size to compensate.
@DarkFenX
Copy link
Member

DarkFenX commented May 26, 2019

How does it look for you pre-fix?

Please provide screenshot, as well as some extra info - OS, pyfa version, UI scaling factor if non-100%, screen resolution. Include dependency versions as well if they do not match those listed in requirements.txt.

I might need this info to see if there's better fix for the issue or not. On my rig, left column is shown.

@AaronOpfer
Copy link
Contributor Author

image

Debian Stable, pyfa is master 1d8c9d2, UI scaling factor I think is 125% but I'm not sure. 2560x1440 resolution.

pip freeze

asn1crypto==0.24.0
beautifulsoup4==4.6.3
certifi==2018.10.15
cffi==1.11.5
chardet==3.0.4
cryptography==2.4.1
cycler==0.10.0
diskcache==3.1.0
filelock==3.0.10
idna==2.7
kiwisolver==1.0.1
Logbook==1.4.1
markdown2==2.3.6
matplotlib==3.0.2
numpy==1.15.4
packaging==18.0
pluggy==0.8.0
py==1.7.0
pycparser==2.19
pyparsing==2.3.0
Pypubsub==4.0.0
python-dateutil==2.7.5
PyYAML==3.13
requests==2.20.1
roman==3.1
six==1.11.0
snakeviz==2.0.0
SQLAlchemy==1.2.14
toml==0.10.0
tornado==6.0.2
tox==3.5.3
urllib3==1.24.1
virtualenv==16.1.0
wxPython==4.0.3

@DarkFenX
Copy link
Member

DarkFenX commented May 27, 2019

Which DE and display server do you use? Fractional scaling factors are experimental as far as i know. They might affect that. Also, wx 4.0.3 might too.

This is how it looks on my debian testing rig (wx 4.0.4, wayland, gnome, 100% scale) before the fix:

image

@DarkFenX
Copy link
Member

That said, I do not see anything bad in making the window a little bigger, merging.

@DarkFenX DarkFenX merged commit d81acc1 into pyfa-org:master May 27, 2019
@AaronOpfer AaronOpfer deleted the esi_import_sizing branch September 20, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants