Updates to Abyss room-wide and localized weather effects

[fonsuiplaysvideogames]

Addressing #1880 :

1. Added relevant room-wide and localized effects to drones
2. Removed stacking penalties from room-wide and localized effects
3. Removed erroneous comments

@DarkFenX Please let me know if there are any issues with this code so that I can fix it up if necessary. Thanks!

[fonsuiplaysvideogames]

@DarkFenX @blitzmann

Can you guys let me know if this code needs changes in order to be merged in?

[DarkFenX]

We're somewhat inactive. I believe blitzz went back to inactivity and i have IRL pressure, so cannot keep up with pyfa development needs. I will check your PR now.

[DarkFenX]

@fonsuiplaysvideogames why did you remove stacking penalties from multiple abyssal cloud effects? Are you confident they are not stacking penalized?

Just to clarify how stacking penalties work in EVE: every attribute has flag stackable. If it is true, then it cannot be stacking penalized at all (e.g. cap amount). If it is true, then it can be. Then, there are modifications applied to it by various items. There are several item categories which are immune to stacking penalization (e.g. implants' modifications are immune, but wormhole effects are not). And, as far as I remember, items carrying those effects do not belong to immune categories. Has it been changed at some point?

[fonsuiplaysvideogames]

I am uncertain of the specific rules you're describing, but what I do know is that the observed value in-game matched the value in pyfa when I had the stacking penalties removed, and when the stacking penalties were in I got inconsistent values.

[DarkFenX]

@fonsuiplaysvideogames could you give some specific example? Full fit, projected effects/environment, attribute values, just so I could confirm it myself before merging. If the fit is sensitive, send it to phoenix@mail.ru.

There are multiple possible fixes for this, removing stacking penalty is just one of solutions, and depending on the data there might be different solutions (like alternate stacking penalty chains).

[fonsuiplaysvideogames]

Nothing sensitive, just a testing fit I was using on Singularity. Two Drone Scope Chip II rigs, an Omnidirectional Tracking Enhancer, and a range scripted Omnidirectional Tracking Link on a bare ship was generating different results in-game in a Dark Abyss site and in pyfa.

[DarkFenX]

If you were looking at drone optimal range - negative and positive modifications are stacking penalized separately. Everything you listed is a positive modification, and optimal range penalty from darks is a negative modification, so at least in theory removing stacking penalty flag should not affect final number (unless you had more negative modifications applied, like TDs).

[blitzmann]

I'm around, but focusing what little free time I have on trying to figure out i18n stuff.

@DarkFenX you seem to be much more in the know with what's going on with this, so I'm going to defer to you unless you need some assistance with it.

[fonsuiplaysvideogames]

If I wanted to change this to add the effects to drones without changing the stacking penalty code, what would be the best way to go about it? I've updated the code on my fork to restore the stacking penalty eligibility, while keeping the drone code.

[DarkFenX]

@fonsuiplaysvideogames looks good with the changes. As for the stacking penalty issue - please create separate ticket with some concrete data to work on, this way we will be able to figure out what would be a way to fix it properly.