Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupervised Heterogeneous Graph Learning #3189

Merged
merged 26 commits into from
Mar 27, 2022
Merged

Conversation

Yonggie
Copy link
Contributor

@Yonggie Yonggie commented Sep 21, 2021

added unsupervised heterogeneous graph representation learning example.

examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #3189 (e9d614f) into master (0847344) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head e9d614f differs from pull request most recent head 690f14b. Consider uploading reports for the commit 690f14b to get more accurate results

@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
- Coverage   82.44%   82.31%   -0.13%     
==========================================
  Files         310      310              
  Lines       15934    15932       -2     
==========================================
- Hits        13136    13115      -21     
- Misses       2798     2817      +19     
Impacted Files Coverage Δ
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/io/tu.py 93.58% <0.00%> (-2.57%) ⬇️
torch_geometric/nn/models/mlp.py 98.41% <0.00%> (-1.59%) ⬇️
torch_geometric/transforms/gdc.py 77.94% <0.00%> (-1.03%) ⬇️
torch_geometric/data/dataset.py 96.80% <0.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/rgat_conv.py 83.76% <0.00%> (-0.53%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0847344...690f14b. Read the comment docs.

@Yonggie
Copy link
Contributor Author

Yonggie commented Sep 22, 2021

@rusty1s Hi, it's ready for review :)

@rusty1s rusty1s changed the title added unsupervised hetero method Unsupervised Heterogeneous Graph Learning Feb 7, 2022
Copy link

@vincentvic vincentvic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the class AddMetaPaths for a cleaner implementation

examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
examples/hetero/hetero_unsupervised_dblp.py Outdated Show resolved Hide resolved
@Yonggie
Copy link
Contributor Author

Yonggie commented Mar 10, 2022

It's been quite a long time since I wrote this code. I may take a while to catch it up again.

@Yonggie
Copy link
Contributor Author

Yonggie commented Mar 10, 2022

I implemented DMGI using torch_geometric, but it seems the performance is not as good as the paper said. Original implementation: https://github.com/pcy1302/DMGI

@rusty1s
Copy link
Member

rusty1s commented Mar 10, 2022

Thanks for the updates @Yonggie, and sorry for the delay. We will try to get this merged in the upcoming week.

@rusty1s
Copy link
Member

rusty1s commented Mar 10, 2022

Do you know of any differences between this implementation and the official one?

@Yonggie
Copy link
Contributor Author

Yonggie commented Mar 11, 2022

I just found a small difference in the encoder and changed the code. but it still seems not good enough. And another weird thing is valid score and test score are exactly the same.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@rusty1s rusty1s merged commit b6624fe into pyg-team:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heterogeneous Unsupervised Graph Representation Learning
4 participants