Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeteroData support to RemoveIsolatedNodes #4479

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

Padarn
Copy link
Contributor

@Padarn Padarn commented Apr 15, 2022

This PR adds HeteroData support to the RemoveIsolatedNodes transform, closing #4013.

This is achieved by looping through the different node types and removing them one at a time.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4479 (8442a1d) into master (3f0019f) will decrease coverage by 0.04%.
The diff coverage is 90.74%.

❗ Current head 8442a1d differs from pull request most recent head a38c592. Consider uploading reports for the commit a38c592 to get more accurate results

@@            Coverage Diff             @@
##           master    #4479      +/-   ##
==========================================
- Coverage   82.69%   82.64%   -0.05%     
==========================================
  Files         313      313              
  Lines       16240    16303      +63     
==========================================
+ Hits        13429    13474      +45     
- Misses       2811     2829      +18     
Impacted Files Coverage Δ
...orch_geometric/transforms/remove_isolated_nodes.py 90.47% <90.74%> (-4.27%) ⬇️
torch_geometric/data/hetero_data.py 93.10% <0.00%> (-2.30%) ⬇️
torch_geometric/data/data.py 90.70% <0.00%> (-1.41%) ⬇️
torch_geometric/loader/link_neighbor_loader.py 89.52% <0.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/sage_conv.py 100.00% <0.00%> (ø)
torch_geometric/nn/conv/message_passing.py 99.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0019f...a38c592. Read the comment docs.

@Padarn Padarn changed the title hetero isolated support Add HeteroData support to RemoveIsolatedNodes Apr 15, 2022
@rusty1s rusty1s merged commit 5fe7077 into pyg-team:master Apr 20, 2022
wilcoln pushed a commit to wilcoln/pytorch_geometric that referenced this pull request Apr 21, 2022
* hetero isolated support

* update

* typo

Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'BaseStorage' object has no attribute 'edge_index' for hetero graph
2 participants