Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphstore): support num_nodes, enabling Tuple[FeatureStore, GraphStore] in LightningLinkData #5270

Merged
merged 11 commits into from
Aug 26, 2022

Conversation

mananshah99
Copy link
Contributor

There is still cleanup work to be done around LightningNodeData, LightningLinkData, and how we fetch num_nodes. This is simply a hotfix to have functionality working, the cleanup will happen shortly.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #5270 (b3de013) into master (df93d23) will decrease coverage by 1.75%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master    #5270      +/-   ##
==========================================
- Coverage   85.08%   83.33%   -1.76%     
==========================================
  Files         337      337              
  Lines       18607    18634      +27     
==========================================
- Hits        15832    15528     -304     
- Misses       2775     3106     +331     
Impacted Files Coverage Δ
torch_geometric/data/graph_store.py 92.13% <87.50%> (-0.55%) ⬇️
torch_geometric/data/data.py 91.35% <100.00%> (+0.08%) ⬆️
torch_geometric/data/hetero_data.py 94.54% <100.00%> (+0.08%) ⬆️
torch_geometric/data/lightning_datamodule.py 48.82% <100.00%> (+16.84%) ⬆️
torch_geometric/loader/link_neighbor_loader.py 94.70% <100.00%> (+1.62%) ⬆️
torch_geometric/testing/feature_store.py 100.00% <100.00%> (ø)
torch_geometric/testing/graph_store.py 100.00% <100.00%> (ø)
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/profile/profile.py 37.89% <0.00%> (-26.32%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

torch_geometric/data/lightning_datamodule.py Outdated Show resolved Hide resolved
torch_geometric/data/lightning_datamodule.py Outdated Show resolved Hide resolved
torch_geometric/testing/feature_store.py Outdated Show resolved Hide resolved
@mananshah99
Copy link
Contributor Author

Completely agree that we need to stop replicating this logic across PyG. My preference is to handle this in a separate PR, and merge this one so we maintain correctness for link prediction with remote backends. The separate PR will be out soon.

test/data/test_lightning_datamodule.py Outdated Show resolved Hide resolved
torch_geometric/data/lightning_datamodule.py Outdated Show resolved Hide resolved
torch_geometric/data/lightning_datamodule.py Outdated Show resolved Hide resolved
torch_geometric/testing/feature_store.py Outdated Show resolved Hide resolved
Copy link
Contributor

@yaoyaowd yaoyaowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

@mananshah99 mananshah99 changed the title hotfix(data): support Tuple[FeatureStore, GraphStore] in LightningLinkData feat(graphstore): support num_nodes, enabling Tuple[FeatureStore, GraphStore] in LightningLinkData Aug 26, 2022
@rusty1s rusty1s merged commit 6f6f08c into master Aug 26, 2022
@rusty1s rusty1s deleted the fix_lightning_link_data branch August 26, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants