-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphstore): support num_nodes
, enabling Tuple[FeatureStore, GraphStore]
in LightningLinkData
#5270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5270 +/- ##
==========================================
- Coverage 85.08% 83.33% -1.76%
==========================================
Files 337 337
Lines 18607 18634 +27
==========================================
- Hits 15832 15528 -304
- Misses 2775 3106 +331
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Completely agree that we need to stop replicating this logic across PyG. My preference is to handle this in a separate PR, and merge this one so we maintain correctness for link prediction with remote backends. The separate PR will be out soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment.
Tuple[FeatureStore, GraphStore]
in LightningLinkData
num_nodes
, enabling Tuple[FeatureStore, GraphStore]
in LightningLinkData
There is still cleanup work to be done around
LightningNodeData
,LightningLinkData
, and how we fetchnum_nodes
. This is simply a hotfix to have functionality working, the cleanup will happen shortly.