Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeaturePropagation as a transform #5387

Merged
merged 24 commits into from
Sep 13, 2022
Merged

Conversation

EdisonLeeeee
Copy link
Contributor

@EdisonLeeeee EdisonLeeeee commented Sep 8, 2022

This PR implements the FeaturePropagation method proposed in On the Unreasonable Effectiveness of Feature propagation in Learning on Graphs with Missing Node Features.

Based on the prev discussion in this issue, I implement FeaturePropagation as a transform. A minimal example to reproduce the experiments is also provided.

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you adding this. Please add a test for this feature. Left some initial comments, will take a look again in a few days.

torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
@wsad1 wsad1 self-requested a review September 9, 2022 13:09
@emalgorithm
Copy link
Contributor

Hi, the author of the paper here 👋 . Thanks a lot for working on this and let me know if you have any question!

torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this. left some final comments.

test/transforms/test_feature_propagation.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
torch_geometric/transforms/feature_prop.py Outdated Show resolved Hide resolved
@EdisonLeeeee
Copy link
Contributor Author

EdisonLeeeee commented Sep 13, 2022

@wsad1 Thanks for your thorough reviews. Would it be able to merge now?

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Made some minor modifications.

@rusty1s rusty1s enabled auto-merge (squash) September 13, 2022 10:54
@rusty1s rusty1s linked an issue Sep 13, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #5387 (fe33faa) into master (af951b8) will increase coverage by 0.03%.
The diff coverage is 97.29%.

❗ Current head fe33faa differs from pull request most recent head 9690d46. Consider uploading reports for the commit 9690d46 to get more accurate results

@@            Coverage Diff             @@
##           master    #5387      +/-   ##
==========================================
+ Coverage   83.37%   83.40%   +0.03%     
==========================================
  Files         346      347       +1     
  Lines       18805    18842      +37     
==========================================
+ Hits        15679    15716      +37     
  Misses       3126     3126              
Impacted Files Coverage Δ
torch_geometric/graphgym/config_store.py 81.69% <ø> (+0.65%) ⬆️
torch_geometric/transforms/feature_propagation.py 97.22% <97.22%> (ø)
torch_geometric/transforms/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 9625bbd into pyg-team:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNNs with Missing Node Features 🚀
5 participants