Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node_attributes shape in read_tu_data #5441

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Fix node_attributes shape in read_tu_data #5441

merged 4 commits into from
Sep 14, 2022

Conversation

flandolfi
Copy link
Contributor

Hi, this should fix #5411. node_attributes were not reshaped if ndim == 1.

Francesco

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #5441 (c70fa94) into master (83d0f32) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #5441      +/-   ##
==========================================
- Coverage   83.40%   83.39%   -0.02%     
==========================================
  Files         347      347              
  Lines       18842    18846       +4     
==========================================
+ Hits        15716    15717       +1     
- Misses       3126     3129       +3     
Impacted Files Coverage Δ
torch_geometric/io/tu.py 90.69% <25.00%> (-3.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s enabled auto-merge (squash) September 14, 2022 14:57
@rusty1s rusty1s merged commit b3c0318 into pyg-team:master Sep 14, 2022
@flandolfi flandolfi deleted the tu-fix branch September 14, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The the feature dim of data.x is zero in Proteins dataset with the pyg version after 2.0.5
2 participants