Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Type Hints] nn.max_pool_neighbor_x #5703

Merged
merged 8 commits into from
Oct 15, 2022
Merged

[Type Hints] nn.max_pool_neighbor_x #5703

merged 8 commits into from
Oct 15, 2022

Conversation

akash-vartak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #5703 (582fc8c) into master (2a64140) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 582fc8c differs from pull request most recent head bb6f4ab. Consider uploading reports for the commit bb6f4ab to get more accurate results

@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
- Coverage   83.83%   83.83%   -0.01%     
==========================================
  Files         349      349              
  Lines       19276    19273       -3     
==========================================
- Hits        16160    16157       -3     
  Misses       3116     3116
Impacted Files Coverage Δ
torch_geometric/nn/pool/max_pool.py 100.00% <100.00%> (ø)
torch_geometric/nn/pool/avg_pool.py 100.00% <0.00%> (ø)
torch_geometric/transforms/random_shear.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rusty1s
rusty1s approved these changes Oct 15, 2022
View reviewed changes
torch_geometric/nn/pool/max_pool.py Outdated Show resolved Hide resolved
@rusty1s rusty1s enabled auto-merge (squash) October 15, 2022 06:55
@rusty1s rusty1s disabled auto-merge October 15, 2022 06:57
@rusty1s rusty1s merged commit ded47de into pyg-team:master Oct 15, 2022
@rusty1s rusty1s mentioned this pull request Oct 15, 2022
Closed
JakubPietrakIntel pushed a commit to JakubPietrakIntel/pytorch_geometric that referenced this pull request Nov 25, 2022
@akash-vartak @pre-commit-ci
@rusty1s @JakubPietrakIntel
[Type Hints] nn.max_pool_neighbor_x (pyg-team#5703)
75daf5e 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@akash-vartak akash-vartak

Labels
0 - Priority P0 nn type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-vartak @rusty1s