Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INF] Add pre-commit hooks to repository #601

Closed
ericmjl opened this issue Oct 29, 2019 · 1 comment · Fixed by #602
Closed

[INF] Add pre-commit hooks to repository #601

ericmjl opened this issue Oct 29, 2019 · 1 comment · Fixed by #602

Comments

@ericmjl
Copy link
Member

ericmjl commented Oct 29, 2019

Pre-commit hooks are a great way to push code style checks to the development machine, so that they automatically happen and thus we don't have to wait for the CI system to finish to discover that it failed only on code style.

I will add in instructions to get started with pre-commit, so that a bunch of checks are automatically done pre-commit.
@ericmjl ericmjl mentioned this issue Oct 29, 2019
Merged
@hectormz
Copy link
Collaborator

I was just thinking about proposing optional pre-commit hooks yesterday! awesome

hectormz pushed a commit that referenced this issue Oct 29, 2019
@ericmjl @hectormz
[INF] Install pre-commit into repository #601 (#602)
8dcf387 
* Add pre-commit to dev env spec

* add  pre-commit

* Pre-commit text file fixes

* Added pre-commit hooks to install command

* Add instructions on pre-commit hooks

* add default -l 79 to black

* fix environment yaml spec filename

* add pre-commit to requirements-dev.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[INF] Install pre-commit into repository #601 pyjanitor-devs/pyjanitor
2 participants
@ericmjl @hectormz