Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix deprecation warning, deprecations and type hints #383

Merged
merged 1 commit into from
May 29, 2019

Conversation

hectormz
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • Fix f-string for argument deprecation warning (!!)
  • Updated deprecated arguments in tests
  • Add type hints to some function returns

This PR resolves #59 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.

Quick Check

To do a very quick check that everything is correct, follow these steps below:

  • Run the command make check from pyjanitor's top-level directory. This will automatically run:
    • black formatting
    • pycodestyle checking
    • running the test suite
    • docs build

Once done, please check off the check-box above.

If make check does not work for you, you can execute the commands listed in the Makefile individually.

Code Changes

If you are adding code changes, please ensure the following:

  • Ensure that you have added tests.
  • Run all tests ($ pytest .) locally on your machine.
    • Check to ensure that test coverage covers the lines of code that you have added.
    • Ensure that all tests pass.

Relevant Reviewers

Please tag maintainers to review.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #383 into dev will increase coverage by 4.82%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #383      +/-   ##
==========================================
+ Coverage   88.19%   93.01%   +4.82%     
==========================================
  Files          10       10              
  Lines         754      931     +177     
==========================================
+ Hits          665      866     +201     
+ Misses         89       65      -24

@ericmjl
Copy link
Member

ericmjl commented May 29, 2019

We're good here, merging. Thanks @HectorM14!

@ericmjl ericmjl merged commit 0430d5c into pyjanitor-devs:dev May 29, 2019
@hectormz
Copy link
Collaborator Author

Was there something I could/should have done to restart the pipelines?

@ericmjl
Copy link
Member

ericmjl commented May 29, 2019

That's under my control for the time being, while I hack on robustifying the Pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Naming conventions
2 participants