-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TST] Add test docstrings to ml, biology, chemistry modules #649
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #649 +/- ##
=======================================
Coverage 92.36% 92.36%
=======================================
Files 16 16
Lines 524 524
=======================================
Hits 484 484
Misses 40 40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor change requested, @hectormz. As always, you've done a wonderful job here 😄.
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
@ericmjl thanks for the feedback, just updated it! |
Thanks @hectormz! |
More to follow...eventually... |
No pressure! 😄 |
Bitesize. It's actually also a really nice to gain some more familiarity with parts of the codebase I'm not familiar with. So good for new and old contributors. |
PR Description
Please describe the changes proposed in the pull request:
ml
biology
chemistry
I did not write any of the original functions or tests, and am open to feedback for better descriptions.
This PR partially addresses #306.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.rst
under the latest version header (i.e. the one that is "on deck") describing the contribution.Quick Check
To do a very quick check that everything is correct, follow these steps below:
make check
from pyjanitor's top-level directory. This will automatically run:Once done, please check off the check-box above.
If
make check
does not work for you, you can execute the commands listed in the Makefile individually.Relevant Reviewers
Please tag maintainers to review.