-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Aesara support and fix PyTensor compatibility #44
Conversation
This simplifies testing & upcoming fixes related to changes in shape handling in PyTensor.
@ricardoV94 @aseyboldt the tests here are failing with this:
But the shape of
Am I missing something? |
We keep the shape dependencies since pymc-devs/pytensor#280 This allows us to potentially As a solution you can use |
There's a distinction between |
49e590a
to
5316cfc
Compare
In an attempt to fix the CI environment creation.
The inspiration for the NumPy minimum version bumps came from conda/conda-build#4498 but it didn't help. The successful 3.8 jobs were using an old PyTensor version.. Let's see what Python 3.11 brings |
Ah, cool! I did that last night and didn't realize it succeeded! 🚀 Unless sunode has some explicit numpy version requirements then it's best to pin implicitly. |
This simplifies testing & upcoming fixes related to changes in shape handling in PyTensor.