Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make workflows repo agnostic #5

Merged
merged 8 commits into from
May 16, 2024
Merged

refactor: make workflows repo agnostic #5

merged 8 commits into from
May 16, 2024

Conversation

castdrian
Copy link

  • refactors the workflows to be repo agnostic with all values being dynamically obtained from the source branch
    note: whilst doing this I came across the fact that the go patcher hardcodes output and plist values, that should probably be refactored to use cli args

pylixonly
pylixonly approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@pylixonly pylixonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this and pray

@pylixonly pylixonly merged commit f1fb914 into pyoncord:main May 16, 2024
@castdrian castdrian deleted the cleanup branch May 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylixonly pylixonly pylixonly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@castdrian @pylixonly