CI: Add a test job for Cygwin #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no single user/group with UID/GID=0 under Cygwin unlike Unix. Skip the tests that assume this for now.
There are some tests skipped because of missing docutils, but cygwin currently is missing a docutils package for Python 3.9
Closed
|
This looks great. I wanted to take the opportunity here to notice that there was some redundancy across the two identified test modules and to consolidate that behavior, so I've done that in 1d98a15. It's entirely an iteration on your work and not a criticism. |
|
A bit of additional context: I'm not quite sure why the tests try to set root uid/gid... maybe just because they are always available and not the current user? I tried something similar by using the "Adminstrator" account and "Administrators" group on Windows first, which Windows is supposed to have by default, but for some reason the GHA image is missing the former. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a Cygwin developer, but since the MSYS2 patches are touching Cygwin code paths this could be helpful in preventing regressions in that area.
Example run on my fork: https://github.com/lazka/distutils/runs/4569103775?check_suite_focus=true