Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose various function in tags publicly #231

Merged
merged 61 commits into from
Nov 25, 2019
Merged

Expose various function in tags publicly #231

merged 61 commits into from
Nov 25, 2019

Conversation

brettcannon
Copy link
Member

Closes #187 and should open the way for pip to start using packaging.tags.

@brettcannon
Update to mypy 0.740
6bfc7bd
@brettcannon
Change Optional[bool] to bool as None is not expected
d703c2d
@brettcannon
Tweak docsstrings to follow the rest of the file
0b9e724
@brettcannon
Make linters happy
c722ee0
@brettcannon
Initial implementation of public *_tags() functions
8c2c701
@brettcannon
Tweak a test name
fb58d28
@brettcannon
Add tests for cpython_tags()
4494b1c
@brettcannon
Add tests for pypy_tags()
d5f8730
@brettcannon
Add tests for generic_tags()
2495a36
@brettcannon
Add tests for compatible_tags()
5ccac11
@brettcannon
Type _generic_interpreter()
ff3e41f
@brettcannon
Add tests for _platform()
9f398c5
@brettcannon
Remove now-dead code
8f54af0
@brettcannon
Fix the docstring for _py_interpreter_range()
11b9bed
@brettcannon
Expose mac_platforms() publicly
c8e90d9 
Along the way, make all platform-related functions generators.
@brettcannon
Make some type hints on parameters more readable
c091101
@brettcannon
Fix some whitespace
f50ce38
@brettcannon
Fix up tests for mac_platforms() exposure and making platform functio…
d0b5b56 
…ns generators
@brettcannon
Document new public functions
5ef9af0
This was referenced Nov 12, 2019
Open
Closed
xavfernandez
xavfernandez reviewed Nov 12, 2019
View reviewed changes
docs/tags.rst Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
docs/tags.rst Outdated Show resolved Hide resolved
packaging/tags.py Outdated Show resolved Hide resolved
This was referenced Nov 13, 2019
Closed
Closed
@brettcannon
Copy link
Member Author

This should also close #184

@brettcannon
Copy link
Member Author

I will also note that _generic_abi() could probably be changed to return a sequence and leave out "none".

chrahunt
chrahunt reviewed Nov 15, 2019
View reviewed changes
packaging/tags.py Outdated Show resolved Hide resolved
@brettcannon
Copy link
Member Author

OK, I think I have addressed everything at this point. Let me know if you need anything for this PR before I merge it.

chrahunt
chrahunt approved these changes Nov 23, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other minor comment, but I have no problem addressing this as a separate issue.

packaging/tags.py Outdated Show resolved Hide resolved
@chrahunt chrahunt mentioned this pull request Nov 23, 2019
Merged
@brettcannon
Copy link
Member Author

@chrahunt PTAL

@chrahunt chrahunt mentioned this pull request Nov 24, 2019
Merged
@chrahunt
Copy link
Member

LGTM!

@brettcannon brettcannon merged commit 41b0ad5 into pypa:master Nov 25, 2019
@brettcannon brettcannon deleted the expose-tags branch November 25, 2019 18:59
@brettcannon
Copy link
Member Author

Thanks everyone for working on this! I know it was a slog to get through.

@pradyunsg
Copy link
Member

Hurrah! Many thanks for all the work here folks! ^>^

@jsirois jsirois mentioned this pull request Dec 21, 2019
Closed
@xavfernandez
Copy link
Member

A new packaging release (20.0 ?) would be lovely to unlock pypa/pip#7354 🙏

@di
Copy link
Sponsor Member

di commented Jan 2, 2020

@xavfernandez I think we need to merge #221 and #234 first.

@chrahunt
Copy link
Member

chrahunt commented Jan 2, 2020

Only #221 is required to prevent breaking something that currently works in pip. #234 is a change to existing behavior that could be evaluated independently in its own time if needed.

@pradyunsg
Copy link
Member

@chrahunt In that case, I think we can go ahead and make a release.

@pypa/packaging-committers Any concerns with making a release? If not, let's go ahead and make one. :)

@pradyunsg
Copy link
Member

Whoops -- I just saw #252 (which is now crosslinked, so yay?)

@chrahunt chrahunt mentioned this pull request Jan 25, 2020
Closed
McSinyx
McSinyx reviewed Sep 19, 2021
View reviewed changes
docs/tags.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

@McSinyx McSinyx McSinyx left review comments

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
packaging.tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow customizing generation of tags
6 participants
@brettcannon @chrahunt @pradyunsg @xavfernandez @di @McSinyx