Add support for PEP 730 iOS tags. #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
requested changes
Sep 26, 2024
brettcannon
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 730 adds support for iOS as a supported platform. This PR adds support for determining the platform tags compatible with the current iOS installation.
iOS version support is similar to macOS; if the current platform specifies a version of X.Y, any wheel tagged with a binary version <= X.Y should be compatible. This PR uses 12.0 as the minimum possible iOS version tag to check, as that is the oldest version that is known to have sufficient features to run CPython.
It will check every possible minor version X.0 - X.9; this does result in iOS minor versions that don't exist (e.g., there was no version 12.6-12.9). Having only legal versions would require constant updating of the source; having an extra few tags should only a represent a minor overhead when evaluating candidate wheels, and there's never been an iOS version with a minor > 8 (14.8 and 15.8).