Most of the tests in tests/functional/test_install_cleanup.py aren't testing anything

[dstufft]

Since pip 6 most installations use a randomized build directory, and in pip 7 all installations do unless you specifically mention a directory using --build. However the tests in tests/functional/test_install_cleanup.py assume the old static build directory. We also might not need many of these tests since scripttest ensures there are no tmp dirs left over.

[pradyunsg]

So, just trim the useless tests correct?

[deveshks]

If I understand the issue correctly, there are tests in test_install_cleanup.py, which are using the old static build directory via build = script.venv_path / "build" (e.g here and here etc.

So to address the issue, we would need to remove all such tests. I have made deveshks@b24cbbc to remove those tests.

If the changes are as expected, I can go ahead and create a PR for the same

[pradyunsg]

@deveshks Yea, that commit looks about right to me. :)

[deveshks]

Yea, that commit looks about right to me. :)

Thanks, I have gone ahead and created a PR for the same