Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tests_install_cleanup tests using static build dir #8141

Merged
merged 1 commit into from
May 23, 2020

Conversation

deveshks
Copy link
Contributor

Fixed and closes #2640

Removing tests in test_install_cleanup.py, which are using the old static build directory.

@deveshks deveshks closed this Apr 26, 2020
@deveshks deveshks reopened this Apr 26, 2020
@deveshks deveshks force-pushed the remove-unused-install-cleanup-tests branch from 45d16b3 to 19dfec9 Compare April 26, 2020 04:45
@deveshks deveshks force-pushed the remove-unused-install-cleanup-tests branch from 19dfec9 to b4d8523 Compare May 21, 2020 14:09
@deveshks
Copy link
Contributor Author

Thanks for the approval @pradyunsg . Could I get this merged as well?

@pradyunsg pradyunsg merged commit 2876bf7 into pypa:master May 23, 2020
@pradyunsg pradyunsg added the C: tests Testing and related things label May 23, 2020
@deveshks deveshks deleted the remove-unused-install-cleanup-tests branch May 23, 2020 11:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most of the tests in tests/functional/test_install_cleanup.py aren't testing anything
2 participants