Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do basic syntax checks on the RECORD file when installing a wheel #11762

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Do basic syntax checks on the RECORD file when installing a wheel #11762

wants to merge 3 commits into from

Commits on Jan 29, 2023

  1. Remove the csv_io_kwargs function 

    This function made sense when it still had different logic based on
Python 2/3. Nowadays, it's just unnecessary.
    @SpecLad
    SpecLad committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    b85ac0a View commit details
    Browse the repository at this point in the history

  2. Do basic syntax checks on the RECORD file when installing a wheel 

    For now, only check requirements specified in the original RECORD
specification (<https://packaging.python.org/en/latest/specifications/recording-installed-packages/#the-record-file>),
without the added constraints from the wheel specification.

Some of the warnings ("invalid digest size" and "duplicate line") should
really be errors, but I was able to find some popular projects that have
these problems (any projects built with sphinx-theme-builder for the former,
zeroconf for the latter). To avoid breaking stuff, keep these as warnings
for now.
    @SpecLad
    SpecLad committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    b0128aa View commit details
    Browse the repository at this point in the history

  3. Add news entries

    @SpecLad
    SpecLad committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    6a8d153 View commit details
    Browse the repository at this point in the history