Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per-requirement --config-settings for editables #12494

Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 27, 2024

Fixes #12480

@sbidoul sbidoul force-pushed the pass-config-settings-to-editable-in-req-file-sbi branch from 5b4bd40 to 24449a2 Compare January 27, 2024 18:09
@sbidoul sbidoul changed the title Per-requirement --config-settings not working for editable_mode Support per-requirement --config-settings for editables Jan 27, 2024
@sbidoul sbidoul force-pushed the pass-config-settings-to-editable-in-req-file-sbi branch 2 times, most recently from 903d7c3 to 4296e5a Compare January 28, 2024 12:15
@sbidoul sbidoul added this to the 24.0 milestone Jan 28, 2024
@sbidoul
Copy link
Member Author

sbidoul commented Jan 28, 2024

If anyone is available to do a quick review here, I can include it in 24.0 too.

Copy link
Contributor

@chrysle chrysle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Minor comments, feel free to discard.

tests/functional/test_pep660.py Show resolved Hide resolved
tests/functional/test_pep660.py Outdated Show resolved Hide resolved
@sbidoul sbidoul force-pushed the pass-config-settings-to-editable-in-req-file-sbi branch from 1bf6fe4 to 7f800a2 Compare January 28, 2024 14:18
@sbidoul sbidoul force-pushed the pass-config-settings-to-editable-in-req-file-sbi branch from 7f800a2 to 1f48ca3 Compare January 29, 2024 21:28
@sbidoul
Copy link
Member Author

sbidoul commented Jan 30, 2024

@pypa/pip-committers no objections with landing this in 24.0?

@sbidoul sbidoul merged commit 99a82b7 into pypa:main Jan 31, 2024
26 checks passed
@sbidoul sbidoul deleted the pass-config-settings-to-editable-in-req-file-sbi branch January 31, 2024 08:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-requirement --config-settings not working for editable_mode
2 participants