Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce ruff/pyupgrade rules (UP) #12936

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Enforce ruff/pyupgrade rules (UP) #12936

merged 3 commits into from
Sep 16, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 24, 2024

@notatallshaw
Copy link
Member

FWIW, enabling pyupgrade rules by default was discussed and the sentiment appeared to be to run it on an ad-hoc basis not to enforce it: #11944 (comment)

UP031 Use format specifiers instead of percent format
UP037 Remove quotes from type annotation
@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Aug 30, 2024
@DimitriPapadopoulos
Copy link
Contributor Author

FWIW, enabling pyupgrade rules by default was discussed and the sentiment appeared to be to run it on an ad-hoc basis not to enforce it: #11944 (comment)

Would you like me to remove UP from the selected ruff rules?

@notatallshaw
Copy link
Member

Would you like me to remove UP from the selected ruff rules?

I'm personally supportivel of UP being a selected rule set, and turning off any particular rules if they're found to be problematic. But pip maintainers may have different opinions (as linked).

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this. We can come back can remove things if we want to.

@pradyunsg pradyunsg merged commit 102d818 into pypa:main Sep 16, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants