Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade urllib3 to 1.26.20 #12944

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Upgrade urllib3 to 1.26.20 #12944

merged 1 commit into from
Sep 3, 2024

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Aug 29, 2024

@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label Sep 2, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@ichard26
Copy link
Member

ichard26 commented Sep 2, 2024

Note that this PR is properly noted in the changelog. It modifies the urllib3 vendor changelog entry already on main, instead of adding a new one which causes the Chronographer check to fail.

@ichard26 ichard26 added this to the 24.3 milestone Sep 2, 2024
@uranusjr uranusjr merged commit a26b0ff into pypa:main Sep 3, 2024
29 checks passed
@webknjaz
Copy link
Member

It modifies the urllib3 vendor changelog entry already on main, instead of adding a new one which causes the Chronographer check to fail.

FTR, this is tracked in sanitizers/chronographer-github-app#35. I'll get to it one day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants