Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'pip cache' command #6391

Merged
merged 40 commits into from
Apr 13, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
04c0b0e
Add 'pip cache' command.
duckinator Apr 8, 2019
b0e7b66
[commands/cache] Refactor + fix linting failures.
duckinator Oct 8, 2019
b9b29b8
[commands/cache] fix 'pip cache info'; don't hide python/abi/platform…
duckinator Oct 8, 2019
c59ced6
[commands/cache] More refactoring of cache command
duckinator Oct 8, 2019
8ae71ad
[commands/cache] Add docs for 'pip cache' command.
duckinator Oct 8, 2019
d57dcd9
[commands/cache] Add news file for cache command.
duckinator Oct 8, 2019
50604be
[commands/cache] Raise errors if wrong number of args.
duckinator Oct 9, 2019
9563dfb
[commands/cache] Refactor get_cache_info().
duckinator Oct 10, 2019
6fb1ee7
[commands/cache] fix linting error.
duckinator Oct 10, 2019
c838a67
[commands/cache] Change pattern suffix from -*.whl to *.whl.
duckinator Oct 10, 2019
61dd0bc
[commands/cache] Use location of wheel cache dir specifically.
duckinator Oct 10, 2019
94a6593
[commands/cache] Add HTML docs for `pip cache`.
duckinator Oct 10, 2019
61a0adc
[commands/cache] Add missing type annotation.
duckinator Oct 10, 2019
554133a
[commands/cache] Add file size information.
duckinator Jan 6, 2020
2d97830
[commands/cache] Minor clean-up.
duckinator Jan 13, 2020
6fa8498
[commands/cache] Avoid use of "(s)" suffix.
duckinator Jan 14, 2020
d74895a
[commands/cache] Normalize path in test.
duckinator Feb 23, 2020
10d1376
[commands/cache] Be explicit about `pip cache` only working on the wh…
duckinator Feb 23, 2020
d9dc76e
[commands/cache] Correct argument name in documentation for `pip cach…
duckinator Mar 4, 2020
f22f69e
[utils/filesystem] Convert `size` to float, for consistent behavior b…
duckinator Mar 4, 2020
03d5ec1
[utils/filesystem] Reformat comment to keep lines <79 characters long.
duckinator Mar 4, 2020
735375f
[commands/cache] Reformat documentation.
duckinator Mar 5, 2020
8cd8c91
[commands/cache] Reformat (more) documentation.
duckinator Mar 5, 2020
63ba6cc
[command/cache, utils/filesystem] Use existing format_size; remove _f…
duckinator Mar 5, 2020
ed9f885
[commands/cache] Reformat output of `pip cache info`
duckinator Mar 5, 2020
f8b67c8
[commands/cache] Fix test_cache_info test.
duckinator Mar 5, 2020
8b518b2
[commands/cache] Make filenames more realistic in tests.
duckinator Mar 5, 2020
d57407a
[commands/cache] Make _find_wheels(), and this `pip cache {list,remov…
duckinator Mar 5, 2020
e1fde1f
[commands/cache] Remove unnecessary re-definition of __init__.
duckinator Mar 5, 2020
e804aa5
[commands/cache] Have `pip cache info` raise an exception if it gets …
duckinator Mar 5, 2020
6e425d8
[tests/functional/cache] Refactor to be less redundant.
duckinator Mar 6, 2020
274b295
[tests/functional/cache] Make fixtures feel less magical.
duckinator Mar 6, 2020
c6b5a52
[tests/functional/test_cache] Always call normcase on cache dir; fix …
duckinator Mar 7, 2020
32ce3ba
[tests/functional/cache] Rewrite all of the pip cache {list,remove} t…
duckinator Mar 10, 2020
ba7c3ac
[tests/functional/test_cache] Add test `pip cache list` with an empty…
duckinator Mar 10, 2020
a20b28d
[tests/functional/test_cache] Split apart tests for `pip cache purge`.
duckinator Mar 10, 2020
8858237
[tests/functional/test_cache] Refactor list_matches_wheel() and remov…
duckinator Mar 10, 2020
b7239f5
[tests/functional/test_cache] Remove unused import.
duckinator Mar 10, 2020
0c4eafa
[tests/functional/test_cache] Fix test on Python 2.7.
duckinator Mar 10, 2020
b988417
[tests/functional/test_cache] Use os.path.join() instead of hard-codi…
duckinator Mar 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[commands/cache] fix 'pip cache info'; don't hide python/abi/platform…
… tags.
  • Loading branch information
duckinator committed Apr 1, 2020
commit b9b29b8c10a18843dfbb0c23a33c073b8de603c2
11 changes: 2 additions & 9 deletions src/pip/_internal/commands/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def get_cache_info(self, options, args):
# type: (Values, List[Any]) -> None
format_args = (
options.cache_dir,
len(self._find_wheels(options, '*.whl'))
len(self._find_wheels(options, '*'))
)
result = textwrap.dedent(
"""\
Expand Down Expand Up @@ -112,11 +112,6 @@ def remove_cache_items(self, options, args):
if not files:
raise CommandError('No matching packages')

wheels = map(self._wheel_info, files)
result = 'Removing cached wheels for:\n'
for wheel in wheels:
result += '- %s\n' % wheel

for filename in files:
os.unlink(filename)
logger.debug('Removed %s', filename)
duckinator marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -128,9 +123,7 @@ def purge_cache(self, options, args):

def _wheel_info(self, path):
# type: (str) -> str
filename = os.path.splitext(os.path.basename(path))[0]
name, version = filename.split('-')[0:2]
return '%s-%s' % (name, version)
return os.path.basename(path)

def _find_wheels(self, options, pattern):
# type: (Values, str) -> List[str]
Expand Down
3 changes: 3 additions & 0 deletions tests/functional/test_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ def test_cache_info(script, monkeypatch):
cache_dir = _cache_dir(script)

assert 'Location: %s' % cache_dir in result.stdout
duckinator marked this conversation as resolved.
Show resolved Hide resolved
# TODO(@duckinator): This should probably test that the number of
# packages is actually correct, but I'm not sure how to do that
# without pretty much re-implementing the entire cache info command.
assert 'Packages: ' in result.stdout


Expand Down