Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set include_package_data=True so wheels include vendor license files. #6899

Closed
wants to merge 5 commits into from

Conversation

jasongrout
Copy link

@jasongrout jasongrout commented Aug 19, 2019

Vendor license info was included in #5213 (merge commit 7a3cbee), and is now available in the sdist package, but not in the wheel package. This commit makes the wheel packages include the vendor license files.

Generating the file list in the wheel before and after this change shows this change results in these additional files in the wheel:

pip/_vendor/README.rst
pip/_vendor/appdirs.LICENSE.txt
pip/_vendor/cachecontrol/LICENSE.txt
pip/_vendor/certifi/LICENSE
pip/_vendor/chardet/LICENSE
pip/_vendor/colorama/LICENSE.txt
pip/_vendor/distlib/LICENSE.txt
pip/_vendor/distro.LICENSE
pip/_vendor/html5lib/LICENSE
pip/_vendor/idna/LICENSE.rst
pip/_vendor/ipaddress.LICENSE
pip/_vendor/lockfile/LICENSE
pip/_vendor/msgpack/COPYING
pip/_vendor/packaging/LICENSE
pip/_vendor/packaging/LICENSE.APACHE
pip/_vendor/packaging/LICENSE.BSD
pip/_vendor/pep517/LICENSE
pip/_vendor/pkg_resources/LICENSE
pip/_vendor/progress/LICENSE
pip/_vendor/pyparsing.LICENSE
pip/_vendor/pytoml/LICENSE
pip/_vendor/requests/LICENSE
pip/_vendor/retrying.LICENSE
pip/_vendor/six.LICENSE
pip/_vendor/urllib3/LICENSE.txt
pip/_vendor/vendor.txt
pip/_vendor/webencodings/LICENSE

Vendor license info was included in pypa#5213 
(merge commit 7a3cbee), and is now
available in the sdist package, but not in the wheel package. This commit
makes the wheel packages include the vendor license files.
@jasongrout
Copy link
Author

I'm not sure if this is the right way to fix this, but it works on the platform I'm developing on. If there is a better way to include the vendor license files in the wheel, please let me know.

@jasongrout
Copy link
Author

The failing tests on windows indicate that this isn't enough of a fix to add license files to the wheel on all platforms. Any suggestions for what to do?

@chrahunt chrahunt closed this Oct 13, 2019
@chrahunt chrahunt reopened this Oct 13, 2019
@chrahunt
Copy link
Member

Closing and reopening since failing build logs were gone.

@chrahunt chrahunt closed this Mar 8, 2020
@chrahunt chrahunt reopened this Mar 8, 2020
@pradyunsg
Copy link
Member

Closing since this is out of date. Please feel free to submit an updated PR if this is still relevant! :)

@pradyunsg pradyunsg closed this Feb 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants