Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines: Test Linux and macOS on Python 3.8 #7321

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 9, 2019

For #7229.

Python 3.8 is now available on Azure Pipelines: https://github.com/microsoft/azure-pipelines-image-generation/issues/1317#issuecomment-551965427.

I wasn't sure what the logic for calculating maxParallel, so I incremented it in the places where I added a new 3.8 job.

Please let me know if it should be adjusted.

This is for Linux and macOS. (See #7320 for Windows, split from this as it's failing.)

@hugovk hugovk force-pushed the azurepipelines-3.8-linux-macos branch from 5a0fda6 to 4127bee Compare November 11, 2019 10:02
@chrahunt chrahunt added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 13, 2020
@deveshks
Copy link
Contributor

deveshks commented Apr 3, 2020

Hi @hugovk ,

Are you still working on this PR to add Python 3.8 support to Linux and MacOS? If not, can I take it up and finish it?

@McSinyx
Copy link
Contributor

McSinyx commented Apr 3, 2020

I think this can basically be merged, the failing test seem unrelated to the change. Just to be sure, @hugovk, please reset the tests (by closing and reopening the PR).

@pfmoore pfmoore closed this Apr 3, 2020
@pfmoore pfmoore reopened this Apr 3, 2020
@deveshks
Copy link
Contributor

deveshks commented Apr 3, 2020

@McSinyx I think that might certainly be the case. Thanks for the update.

@hugovk
Copy link
Contributor Author

hugovk commented Apr 3, 2020

Yep, ready to merge!

@deveshks
Copy link
Contributor

Hi @pradyunsg

If we don't have Python3.8 support for Linux and MacOS, this PR can be looked at for the same, and approved/merged.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt. :)

@pradyunsg pradyunsg merged commit 4416e88 into pypa:master Apr 10, 2020
@hugovk hugovk deleted the azurepipelines-3.8-linux-macos branch April 10, 2020 19:21
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants