Use packaging.tags.Tag to represent tag throughout the code #7563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
chrahunt
changed the title
pradyunsg
approved these changes
Jan 7, 2020
This is the standard type used by packaging.tags. Making this change throughout the code lets us start switching over to using its tag-generating functions in get_supported(). We also get rid of a test, since it was superseded by `__str__` in packaging.tags.Tag.
Since we delegate tag formatting to packaging.tags.Tag, we don't need this function or its tests.
chrahunt
force-pushed
the
maint/use-packaging-tags-tag
branch
from
cd51cff
to
58f175f
Compare
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the standard type used by packaging.tags. Making this change
throughout the code lets us start switching over to using its
tag-generating functions in get_supported().
Progresses #6908. Split from #7354.