Remove unnecessary write_delete_marker_file #7653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
InstallRequirement only checks for a delete marker file in source_dir. Since the result of ensure_build_location is set to source_dir (in ensure_has_source_dir), and ensure_build_location returns a subdirectory of the build_directory to which we write the delete marker file, then this delete marker file is never used.
chrahunt
force-pushed
the
refactor/remove-unnecessary-marker-file
branch
from
c8afd55
to
d028af9
Compare
sbidoul
approved these changes
Jan 26, 2020
|
Thank you for reviewing @sbidoul I will merge this, but if anyone sees an issue later I'm more than happy to address it in a follow up. |
|
@chrahunt I think this should be fine but I'm not a 100% sure (and I never actually managed to look into this in a single sitting, because I ended up prioritizing other stuff over this). |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallRequirement only checks for a delete marker file in source_dir.
Since the result of ensure_build_location is set to source_dir (in
ensure_has_source_dir), and ensure_build_location returns a subdirectory
of the build_directory to which we write the delete marker file, then
this delete marker file is never used.
Progresses #7571.