Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build local directories in place #7882

Merged
merged 5 commits into from
Apr 13, 2020
Merged

Build local directories in place #7882

merged 5 commits into from
Apr 13, 2020

Commits on Apr 12, 2020

  1. build in place

    @sbidoul
    sbidoul committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    88e6e6b View commit details
    Browse the repository at this point in the history

  2. remove _copy_source_tree and friends

    @sbidoul
    sbidoul committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    873f1e6 View commit details
    Browse the repository at this point in the history

  3. fix test_entrypoints_work test 

    Since we now build in place, pip install
calls setup.py in place which in turn creates
fake_pkg.egg-info. Since in this test the package we are installing is in script.temp_path,
we must tell script to expect temporary
files to be created.
    @sbidoul
    sbidoul committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    ace0c16 View commit details
    Browse the repository at this point in the history

  4. fix test_uninstall_console_scripts 

    This particular test checks which files are
created. Since we now build in place, expect the .egg-info directory to be created.
    @sbidoul
    sbidoul committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    877e1cc View commit details
    Browse the repository at this point in the history

  5. Reword based on suggestion 

    Co-Authored-By: Noah <noah.bar.ilan@gmail.com>
    @pradyunsg
    pradyunsg and Noah committed Apr 12, 2020
    Configuration menu
    Copy the full SHA
    9e02a1a View commit details
    Browse the repository at this point in the history