Generate legacy metadata in temporary directory #7978
Conversation
sbidoul
force-pushed
the
remove-pip-egg-info-sbi
branch
from
ced9040
to
2353140
Compare
|
Editable installs need the egg-info to be in the location that it's in for working properly IIRC. Other than that, this all sounds and looks good to me in principle. |
Sure, but does pip need to have |
|
I'm pretty sure that setuptools doesn't see that, so it should be fine to put that in a temporary directory. |
Before it was generated in a pip-egg-info subdirectory of the source dir. This will avoid polluting source dir when we build in place.
sbidoul
force-pushed
the
remove-pip-egg-info-sbi
branch
from
6e59b69
to
fbc3c97
Compare
|
Ok, I added a commit with the full simplification of |
| def _find_egg_info(source_directory, is_editable): | ||
| # type: (str, bool) -> str | ||
| """Find an .egg-info in `source_directory`, based on `is_editable`. | ||
| def _find_egg_info(source_directory): |
There was a problem hiding this comment.
| def _find_egg_info(source_directory): | |
| def _find_egg_info(directory): |
There was a problem hiding this comment.
The function body and docstring also need to match this change :)
Always generate legacy metadata in a temporary directory, even in the editable case. Generating it in the source directory did not add value, because setup.py develop always regenerates the .egg-info directory.
sbidoul
force-pushed
the
remove-pip-egg-info-sbi
branch
from
fbc3c97
to
030578e
Compare
|
Thanks for the review @xavfernandez |
|
@RonnyPfannschmidt this is the PR that removed |
|
When neither the scm nor a pkg-info file are part of the external source tree, setuptools_scm has no way to access the version information |
|
@RonnyPfannschmidt yep, I know the case with setup.py in subdirectory, but in my experience it never worked with |
|
I don't have a reproducer, i observed this breakage before your pr, and AFAIK out of tree builds are coming back due to issue |
|
Ok, then if it's unrelated to this PR, the problem you mentioned on discuss is not new, and is part of the known issues with out of tree builds, as summarized in #7555. |
Progresses #7555 by getting rid of
pip-egg-infoas mentioned in #7882 (comment).Pip generates legacy metadata by calling
setup.py egg_info. For editables, it does that in the source directory, else it does it in apip-egg-infosubdirectory of source dir.To avoid polluting source dir with this
pip-egg-infoif and when we will build in place, use a temporary directory instead.Question to reviewers: can one think if there was a good reason to generate that
pip-egg-infoinside source dir?If this PR sounds reasonable, one can further think about always generating legacy metadata in a temporary directory, even in the editable case. Indeed it looks like[update] this simplification in now part of this PRsetup.py developalways runs egg_info even if the directory is already present. This would vastly simplify this area of the code.