Lazily evaluate the candidate sequence to prevent unneeded distribution downloads #9289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Dec 15, 2020
|
I feel like a full revert of #9264 + release is a better short-term plan, because we know we'll end up in a "clean" state then. |
|
Agreed. |
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
from
a8e0c67
to
cf5824a
Compare
|
Ah, I see. We didn’t do this because this fails to return the installed candidate if its version is not found on the index. |
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
2 times, most recently
from
6dea6da
to
93ec9a2
Compare
uranusjr
changed the title
|
Hopefully this does the trick. |
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
3 times, most recently
from
7de21f1
to
eee31c0
Compare
|
Alright, rebased this to master + re-applying the skip candidate PR. This should be ready to review once 20.3.3 is out. |
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
from
eee31c0
to
6b9f9f8
Compare
edmorley
reviewed
Dec 15, 2020
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
from
6b9f9f8
to
da811b9
Compare
pradyunsg
approved these changes
Dec 19, 2020
pfmoore
reviewed
Dec 19, 2020
pfmoore
approved these changes
Dec 19, 2020
|
I came to merge, but there's conflicts here. |
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
from
6f7285f
to
5bce4e2
Compare
Skip candidate not providing valid metadata This reverts commit 7165ab8.
When the new resolver needs to upgrade a package, it puts the already-installed package in the middle of the candidate list obtained from indexes. But when doing it, the candidate list is eagerly consumed, causing pip to download all candidates.
uranusjr
force-pushed
the
new-resolver-lazy-insert
branch
from
5bce4e2
to
2a25452
Compare
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Jan 23, 2021
jsirois
added a commit
to pex-tool/pip
that referenced
this pull request
Feb 1, 2021
* Merge pull request pypa#9289 from uranusjr/new-resolver-lazy-insert * Merge pull request pypa#9315 from pradyunsg/better-search-errors * Merge pull request pypa#9369 from uranusjr/resolvelib-054 * Merge pull request pypa#9320 from uranusjr/wheel-check-valid Verify built wheel contains valid metadata * Merge pull request pypa#9432 from uranusjr/new-resolver-dedup-on-backtracking Avoid downloading multiple candidates of a same version * Revert "Remove on_returncode parameter from call_subprocess" This reverts commit ab3ee71. * Revert "Remove show_stdout from run_command args" This reverts commit 94882fd. * Revert "Create call_subprocess just for vcs commands" This reverts commit 8adbc21. * Revert "Improve check for svn version string" This reverts commit 1471897. * Revert "Bubble up SubProcessError to basecommand._main" This reverts commit e9f738a. * Additional revert of 7969 Revert additional changes that were made after 7969 and depended on it. * add stdout_only to call_subprocess * vcs: capture subprocess stdout only * Add test for call_subprocess stdout_only * Bump for release * Fix test bitrot. Setuptools released 52.0.0 which killed easy_install support and thus caused tests exercising easy_install to fail. Co-authored-by: Pradyun Gedam <3275593+pradyunsg@users.noreply.github.com> Co-authored-by: Stéphane Bidoul <stephane.bidoul@gmail.com> Co-authored-by: Pradyun Gedam <pradyunsg@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9203, fix #9246 (again).
This PR re-applies the reverted #9264, and adds a fix to the issue that caused it to be reverted in 20.3.2.
The experiement to follow up #9288. I’m not quite sure why we didn’t do this previously… But let’s see if this passes tests.